nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-28 01:34:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix never_loop false positive

Browse Source 
on unconditional break to internal labeled block

ref #9831
This commit is contained in:
Kartavya Vashishtha 2022-11-12 20:36:30 +05:30
parent cad0d3d6da
commit 989986144c
No known key found for this signature in database
GPG Key ID: A50012C2324E5DF0
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clippy_lints/src/loops/never_loop.rs
View File

@ -169,7 +169,8 @@ fn never_loop_expr(expr: &Expr<'_>, main_loop_id: HirId) -> NeverLoopResult {
combine_seq(e, arms)
}
},
ExprKind::Block(b, _) => never_loop_block(b, main_loop_id),
ExprKind::Block(b, None) => never_loop_block(b, main_loop_id),
ExprKind::Block(b, Some(_label)) => absorb_break(never_loop_block(b, main_loop_id)),
ExprKind::Continue(d) => {
let id = d
.target_id

12
tests/ui/never_loop.rs
View File

@ -229,6 +229,18 @@ pub fn test18() {
};
}
// Issue #9831: unconditional break to internal labeled block
pub fn test19() {
fn thing(iter: impl Iterator) {
for _ in iter {
'b: {
// error goes away if we just have the block's value be ().
break 'b;
}
}
}
}
fn main() {
test1();
test2();