nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-29 02:03:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

find_deprecation: deprecation attr may be ill-formed meta.

Browse Source
This commit is contained in:
Mazdak Farrokhzad 2019-11-13 19:32:12 +01:00
parent 695fe96517
commit 91aadf0305
3 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/libsyntax/attr/builtin.rs
View File

@ -665,7 +665,10 @@ fn find_deprecation_generic<'a, I>(sess: &ParseSess,
break
}
let meta = attr.meta().unwrap();
let meta = match attr.meta() {
Some(meta) => meta,
None => continue,
};
depr = match &meta.kind {
MetaItemKind::Word => Some(Deprecation { since: None, note: None }),
MetaItemKind::NameValue(..) => {

11
src/test/ui/deprecation/issue-66340-deprecated-attr-non-meta-grammar.rs Normal file
View File

@ -0,0 +1,11 @@
// The original problem in #66340 was that `find_deprecation_generic`
// called `attr.meta().unwrap()` under the assumption that the attribute
// was a well-formed `MetaItem`.
fn main() {
foo()
}
#[deprecated(note = test)]
//~^ ERROR expected unsuffixed literal or identifier, found `test`
fn foo() {}

8
src/test/ui/deprecation/issue-66340-deprecated-attr-non-meta-grammar.stderr Normal file
View File

@ -0,0 +1,8 @@
error: expected unsuffixed literal or identifier, found `test`
--> $DIR/issue-66340-deprecated-attr-non-meta-grammar.rs:9:21
|
LL | #[deprecated(note = test)]
| ^^^^
error: aborting due to previous error