Rollup merge of #112382 - jyn514:test-download-rustc-macos, r=albertlarsan68

download-rustc: Fix `x test core` on MacOS

before, this hardcoded `.so` as the extension for dynamically linked objects, which is incorrect everywhere except linux.
This commit is contained in:
Dylan DPC 2023-06-07 18:01:31 +05:30 committed by GitHub
commit 90c361c837
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1358,7 +1358,12 @@ impl Step for Sysroot {
// newly compiled std, not the downloaded std.
add_filtered_files("lib", builder.config.ci_rust_std_contents());
let filtered_extensions = [OsStr::new("rmeta"), OsStr::new("rlib"), OsStr::new("so")];
let filtered_extensions = [
OsStr::new("rmeta"),
OsStr::new("rlib"),
// FIXME: this is wrong when compiler.host != build, but we don't support that today
OsStr::new(std::env::consts::DLL_EXTENSION),
];
let ci_rustc_dir = builder.ci_rustc_dir(builder.config.build);
builder.cp_filtered(&ci_rustc_dir, &sysroot, &|path| {
if path.extension().map_or(true, |ext| !filtered_extensions.contains(&ext)) {