nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-02-27 22:34:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move call of is_range_expression() outside of blocks

Browse Source
This commit is contained in:
Hidehito Yabuuchi 2018-03-05 18:20:27 +09:00
parent e13dcd26e3
commit 8e406760a4
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
clippy_lints/src/redundant_field_names.rs
View File

@ -36,17 +36,17 @@ impl LintPass for RedundantFieldNames {
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for RedundantFieldNames {
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
// Do not care about range expressions.
// They could have redundant field name when desugared to structs.
// e.g. `start..end` is desugared to `Range { start: start, end: end }`
if is_range_expression(expr.span) {
return;
}
if let ExprStruct(_, ref fields, _) = expr.node {
for field in fields {
let name = field.name.node;
// Do not care about range expressions.
// They could have redundant field name when desugared to structs.
// e.g. `start..end` is desugared to `Range { start: start, end: end }`
if is_range_expression(expr.span) {
continue;
}
if match_var(&field.expr, name) && !field.is_shorthand {
span_lint_and_sugg (
cx,