From 8da2a5a27c9890100e3b56ec85879e312312b111 Mon Sep 17 00:00:00 2001 From: Tyson Nottingham Date: Sun, 20 Sep 2020 17:40:37 -0700 Subject: [PATCH] rustc_span: avoid unnecessary cloning in byte_pos_to_line_and_col --- compiler/rustc_span/src/caching_source_map_view.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/compiler/rustc_span/src/caching_source_map_view.rs b/compiler/rustc_span/src/caching_source_map_view.rs index 15dd00fb483..9360d5b5abf 100644 --- a/compiler/rustc_span/src/caching_source_map_view.rs +++ b/compiler/rustc_span/src/caching_source_map_view.rs @@ -84,10 +84,10 @@ impl<'sm> CachingSourceMapView<'sm> { let file_valid; if self.source_map.files().len() > 0 { let file_index = self.source_map.lookup_source_file_idx(pos); - let file = self.source_map.files()[file_index].clone(); + let file = &self.source_map.files()[file_index]; if file_contains(&file, pos) { - cache_entry.file = file; + cache_entry.file = file.clone(); cache_entry.file_index = file_index; file_valid = true; } else {