From 9bc7b6f437ed041e4f7e52c1bf7e646e3c088ea5 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Wed, 9 Jul 2014 22:01:31 +0200 Subject: [PATCH] typeck: check casts from pointers to floats, closes #15445 --- src/librustc/middle/typeck/check/mod.rs | 7 +++++++ .../compile-fail/typeck-cast-pointer-to-float.rs | 15 +++++++++++++++ 2 files changed, 22 insertions(+) create mode 100644 src/test/compile-fail/typeck-cast-pointer-to-float.rs diff --git a/src/librustc/middle/typeck/check/mod.rs b/src/librustc/middle/typeck/check/mod.rs index 9f5fcb61f5f..cdf434f4099 100644 --- a/src/librustc/middle/typeck/check/mod.rs +++ b/src/librustc/middle/typeck/check/mod.rs @@ -1219,6 +1219,13 @@ fn check_cast(fcx: &FnCtxt, actual, fcx.infcx().ty_to_string(t_1)) }, t_e, None); + } else if ty::type_is_unsafe_ptr(t_e) && t_1_is_float { + fcx.type_error_message(span, |actual| { + format!("cannot cast from pointer to float directly: `{}` as `{}`; cast through an \ + integer first", + actual, + fcx.infcx().ty_to_string(t_1)) + }, t_e, None); } fcx.write_ty(id, t_1); diff --git a/src/test/compile-fail/typeck-cast-pointer-to-float.rs b/src/test/compile-fail/typeck-cast-pointer-to-float.rs new file mode 100644 index 00000000000..22a0978ef7c --- /dev/null +++ b/src/test/compile-fail/typeck-cast-pointer-to-float.rs @@ -0,0 +1,15 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +fn main() { + let x : i16 = 22; + ((&x) as *const i16) as f32; + //~^ ERROR: cannot cast from pointer to float directly: `*const i16` as `f32` +}