Refactor calls to lint check functions

This commit is contained in:
Yusuke Tanaka 2021-02-11 01:41:52 +09:00 committed by flip1995
parent 89ef26a681
commit 8a8f7b4cf5
No known key found for this signature in database
GPG Key ID: 1CA0DF2AF59D68A5

View File

@ -338,53 +338,24 @@ impl<'tcx> LateLintPass<'tcx> for Transmute {
let from_ty = cx.typeck_results().expr_ty(&args[0]);
let to_ty = cx.typeck_results().expr_ty(e);
let triggered = useless_transmute::check(cx, e, from_ty, to_ty, args);
if triggered {
// If useless_transmute is triggered, the other lints can be skipped.
if useless_transmute::check(cx, e, from_ty, to_ty, args) {
return;
}
let triggered = wrong_transmute::check(cx, e, from_ty, to_ty);
if triggered {
return;
}
let triggered = crosspointer_transmute::check(cx, e, from_ty, to_ty);
if triggered {
return;
}
let triggered = transmute_ptr_to_ref::check(cx, e, from_ty, to_ty, args, qpath);
if triggered {
return;
}
let triggered = transmute_int_to_char::check(cx, e, from_ty, to_ty, args);
if triggered {
return;
}
let triggered = transmute_ref_to_ref::check(cx, e, from_ty, to_ty, args, const_context);
if triggered {
return;
}
let triggered = transmute_ptr_to_ptr::check(cx, e, from_ty, to_ty, args);
if triggered {
return;
}
let triggered = transmute_int_to_bool::check(cx, e, from_ty, to_ty, args);
if triggered {
return;
}
let triggered = transmute_int_to_float::check(cx, e, from_ty, to_ty, args, const_context);
if triggered {
return;
}
let triggered = transmute_float_to_int::check(cx, e, from_ty, to_ty, args, const_context);
if triggered {
return;
}
let triggered = unsound_collection_transmute::check(cx, e, from_ty, to_ty);
if triggered {
return;
}
let triggered = transmutes_expressible_as_ptr_casts::check(cx, e, from_ty, to_ty, args);
if triggered {
return;
let mut linted = wrong_transmute::check(cx, e, from_ty, to_ty);
linted |= crosspointer_transmute::check(cx, e, from_ty, to_ty);
linted |= transmute_ptr_to_ref::check(cx, e, from_ty, to_ty, args, qpath);
linted |= transmute_int_to_char::check(cx, e, from_ty, to_ty, args);
linted |= transmute_ref_to_ref::check(cx, e, from_ty, to_ty, args, const_context);
linted |= transmute_ptr_to_ptr::check(cx, e, from_ty, to_ty, args);
linted |= transmute_int_to_bool::check(cx, e, from_ty, to_ty, args);
linted |= transmute_int_to_float::check(cx, e, from_ty, to_ty, args, const_context);
linted |= transmute_float_to_int::check(cx, e, from_ty, to_ty, args, const_context);
linted |= unsound_collection_transmute::check(cx, e, from_ty, to_ty);
if !linted {
transmutes_expressible_as_ptr_casts::check(cx, e, from_ty, to_ty, args);
}
}
}