nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-05-14 02:49:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix excessive_precision false positive

Browse Source
This commit is contained in:
Josh Mcguigan 2018-10-07 11:38:20 -07:00
parent 63ceabf0cf
commit 8a77a25b8a
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clippy_lints/src/excessive_precision.rs
View File

@ -136,10 +136,10 @@ fn max_digits(fty: FloatTy) -> u32 {
/// Counts the digits excluding leading zeros /// Counts the digits excluding leading zeros
fn count_digits(s: &str) -> usize { fn count_digits(s: &str) -> usize {
// Note that s does not contain the f32/64 suffix // Note that s does not contain the f32/64 suffix, and underscores have been stripped
s.chars() s.chars()
.filter(|c| *c != '-' || *c != '.') .filter(|c| *c != '-' && *c != '.')
.take_while(|c| *c != 'e' || *c != 'E') .take_while(|c| *c != 'e' && *c != 'E')
.fold(0, |count, c| { .fold(0, |count, c| {
// leading zeros // leading zeros
if c == '0' && count == 0 { if c == '0' && count == 0 {

3
tests/ui/excessive_precision.rs
View File

@ -67,4 +67,7 @@ fn main() {
// Inferred type // Inferred type
let good_inferred: f32 = 1f32 * 1_000_000_000.; let good_inferred: f32 = 1f32 * 1_000_000_000.;
// issue #2840
let num = 0.000_000_000_01e-10f64;
} }