nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-12-17 02:54:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add note to or_fun_call, list checked methods

Browse Source
This commit is contained in:
Dániel Buga 2020-06-15 14:55:23 +02:00
parent 923d61222c
commit 848af39310
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
clippy_lints/src/methods/mod.rs
View File

@ -1330,11 +1330,21 @@ declare_clippy_lint! {
}
declare_clippy_lint! {
/// **What it does:** Looks for unnecessary lazily evaluated closures on `Option` and `Result`.
/// **What it does:** As the counterpart to `or_fun_call`, this lint looks for unnecessary
/// lazily evaluated closures on `Option` and `Result`.
///
/// This lint suggests changing the following functions, when eager evaluation results in
/// simpler code:
/// - `unwrap_or_else` to `unwrap_or`
/// - `and_then` to `and`
/// - `or_else` to `or`
/// - `get_or_insert_with` to `get_or_insert`
/// - `ok_or_else` to `ok_or`
///
/// **Why is this bad?** Using eager evaluation is shorter and simpler in some cases.
///
/// **Known problems:** None.
/// **Known problems:** It is possible, but not recommended for `Deref` and `Index` to have
/// side effects. Eagerly evaluating them can change the semantics of the program.
///
/// **Example:**
///