Resolve crate properly across crates

This commit is contained in:
Joshua Nelson 2020-09-26 22:32:20 -04:00
parent b8363295d5
commit 8437d7b1d3
3 changed files with 23 additions and 1 deletions

View File

@ -911,7 +911,7 @@ impl LinkCollector<'_, '_> {
parent_node parent_node
}; };
let module_id = if let Some(id) = base_node { let mut module_id = if let Some(id) = base_node {
id id
} else { } else {
debug!("attempting to resolve item without parent module: {}", path_str); debug!("attempting to resolve item without parent module: {}", path_str);
@ -934,6 +934,17 @@ impl LinkCollector<'_, '_> {
resolved_self = format!("{}::{}", name, &path_str[6..]); resolved_self = format!("{}::{}", name, &path_str[6..]);
path_str = &resolved_self; path_str = &resolved_self;
} }
} else if path_str.starts_with("crate::") {
use rustc_span::def_id::CRATE_DEF_INDEX;
// HACK(jynelson): rustc_resolve thinks that `crate` is the crate currently being documented.
// But rustdoc wants it to mean the crate this item was originally present in.
// To work around this, remove it and resolve relative to the crate root instead.
// HACK(jynelson)(2): If we just strip `crate::` then suddenly primitives become ambiguous
// (consider `crate::char`). Instead, change it to `self::`. This works because 'self' is now the crate root.
resolved_self = format!("self::{}", &path_str["crate::".len()..]);
path_str = &resolved_self;
module_id = DefId { krate: item.def_id.krate, index: CRATE_DEF_INDEX };
} }
match self.resolve_with_disambiguator( match self.resolve_with_disambiguator(

View File

@ -0,0 +1,5 @@
#![crate_name = "inner"]
/// Links to [crate::g]
pub fn f() {}
pub fn g() {}

View File

@ -0,0 +1,6 @@
// aux-build:intra-link-cross-crate-crate.rs
// build-aux-docs
#![crate_name = "outer"]
extern crate inner;
// @has outer/fn.f.html '//a[@href="../inner/fn.g.html"]' "crate::g"
pub use inner::f;