mirror of
https://github.com/rust-lang/rust.git
synced 2025-01-27 23:22:58 +00:00
Rollup merge of #99002 - fee1-dead-contrib:sugg_derive, r=michaelwoerister
suggest adding a derive for #[default] applied to variants cc ``@TaKO8Ki`` as followup to #98873.
This commit is contained in:
commit
7fed4fffb6
@ -1499,10 +1499,16 @@ impl<'a> Resolver<'a> {
|
||||
&& let ModuleKind::Def(DefKind::Enum, def_id, _) = parent_scope.module.kind
|
||||
&& let Some(span) = self.opt_span(def_id)
|
||||
{
|
||||
err.span_help(
|
||||
self.session.source_map().guess_head_span(span),
|
||||
"consider adding `#[derive(Default)]` to this enum",
|
||||
);
|
||||
let source_map = self.session.source_map();
|
||||
let head_span = source_map.guess_head_span(span);
|
||||
if let Ok(head) = source_map.span_to_snippet(head_span) {
|
||||
err.span_suggestion(head_span, "consider adding a derive", format!("#[derive(Default)]\n{head}"), Applicability::MaybeIncorrect);
|
||||
} else {
|
||||
err.span_help(
|
||||
head_span,
|
||||
"consider adding `#[derive(Default)]` to this enum",
|
||||
);
|
||||
}
|
||||
}
|
||||
for ns in [Namespace::MacroNS, Namespace::TypeNS, Namespace::ValueNS] {
|
||||
if let Ok(binding) = self.early_resolve_ident_in_lexical_scope(
|
||||
|
@ -1,4 +1,4 @@
|
||||
pub enum Test { //~ HELP consider adding `#[derive(Default)]` to this enum
|
||||
pub enum Test { //~ HELP consider adding a derive
|
||||
#[default]
|
||||
//~^ ERROR cannot find attribute `default` in this scope
|
||||
First,
|
||||
|
@ -4,11 +4,11 @@ error: cannot find attribute `default` in this scope
|
||||
LL | #[default]
|
||||
| ^^^^^^^
|
||||
|
|
||||
help: consider adding `#[derive(Default)]` to this enum
|
||||
--> $DIR/suggest-default-attribute.rs:1:1
|
||||
help: consider adding a derive
|
||||
|
|
||||
LL + #[derive(Default)]
|
||||
LL ~ pub enum Test {
|
||||
|
|
||||
LL | pub enum Test {
|
||||
| ^^^^^^^^^^^^^
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user