From 7d357190ff8cd5a06117ff1fbb4a739fa67ae44f Mon Sep 17 00:00:00 2001 From: Michael Woerister Date: Tue, 5 Jan 2016 12:29:50 -0500 Subject: [PATCH] [MIR] Implement calling of closures and add missing monomorphization when translating function references. --- src/librustc_trans/trans/mir/constant.rs | 6 +++-- src/librustc_trans/trans/mir/did.rs | 28 +++++++++++++++++++++++- 2 files changed, 31 insertions(+), 3 deletions(-) diff --git a/src/librustc_trans/trans/mir/constant.rs b/src/librustc_trans/trans/mir/constant.rs index 12839df87b1..0f4a0407298 100644 --- a/src/librustc_trans/trans/mir/constant.rs +++ b/src/librustc_trans/trans/mir/constant.rs @@ -89,8 +89,10 @@ impl<'bcx, 'tcx> MirContext<'bcx, 'tcx> { { let ty = bcx.monomorphize(&constant.ty); match constant.literal { - mir::Literal::Item { def_id, kind, substs } => - self.trans_item_ref(bcx, ty, kind, substs, def_id), + mir::Literal::Item { def_id, kind, substs } => { + let substs = bcx.tcx().mk_substs(bcx.monomorphize(&substs)); + self.trans_item_ref(bcx, ty, kind, substs, def_id) + } mir::Literal::Value { ref value } => { self.trans_constval(bcx, value, ty) } diff --git a/src/librustc_trans/trans/mir/did.rs b/src/librustc_trans/trans/mir/did.rs index d4a7a7c8b48..737c3dace2e 100644 --- a/src/librustc_trans/trans/mir/did.rs +++ b/src/librustc_trans/trans/mir/did.rs @@ -21,6 +21,7 @@ use rustc::middle::traits; use rustc::mir::repr::ItemKind; use trans::common::{Block, fulfill_obligation}; use trans::base; +use trans::closure; use trans::expr; use trans::monomorphize; use trans::meth; @@ -38,6 +39,9 @@ impl<'bcx, 'tcx> MirContext<'bcx, 'tcx> { substs: &'tcx Substs<'tcx>, did: DefId) -> OperandRef<'tcx> { + debug!("trans_item_ref(ty={:?}, kind={:?}, substs={:?}, did={})", + ty, kind, substs, bcx.tcx().item_path_str(did)); + match kind { ItemKind::Function => self.trans_fn_ref(bcx, ty, substs, did), ItemKind::Method => match bcx.tcx().impl_or_trait_item(did).container() { @@ -68,6 +72,9 @@ impl<'bcx, 'tcx> MirContext<'bcx, 'tcx> { substs: &'tcx Substs<'tcx>, did: DefId) -> OperandRef<'tcx> { + debug!("trans_fn_ref(ty={:?}, substs={:?}, did={})", + ty, substs, bcx.tcx().item_path_str(did)); + let did = inline::maybe_instantiate_inline(bcx.ccx(), did); if !substs.types.is_empty() || is_named_tuple_constructor(bcx.tcx(), did) { @@ -101,9 +108,14 @@ impl<'bcx, 'tcx> MirContext<'bcx, 'tcx> { trait_id: DefId, substs: &'tcx Substs<'tcx>) -> OperandRef<'tcx> { + debug!("trans_static_method(ty={:?}, method={}, trait={}, substs={:?})", + ty, + bcx.tcx().item_path_str(method_id), + bcx.tcx().item_path_str(trait_id), + substs); + let ccx = bcx.ccx(); let tcx = bcx.tcx(); - let mname = tcx.item_name(method_id); let subst::SeparateVecsPerParamSpace { types: rcvr_type, selfs: rcvr_self, @@ -118,6 +130,9 @@ impl<'bcx, 'tcx> MirContext<'bcx, 'tcx> { match vtbl { traits::VtableImpl(traits::VtableImplData { impl_def_id, substs: imp_substs, .. }) => { assert!(!imp_substs.types.needs_infer()); + + let mname = tcx.item_name(method_id); + let subst::SeparateVecsPerParamSpace { types: impl_type, selfs: impl_self, @@ -130,6 +145,17 @@ impl<'bcx, 'tcx> MirContext<'bcx, 'tcx> { let mthsubsts = tcx.mk_substs(mth.substs); self.trans_fn_ref(bcx, ty, mthsubsts, mth.method.def_id) }, + traits::VtableClosure(data) => { + let trait_closure_kind = bcx.tcx().lang_items.fn_trait_kind(trait_id).unwrap(); + let llfn = closure::trans_closure_method(bcx.ccx(), + data.closure_def_id, + data.substs, + trait_closure_kind); + OperandRef { + ty: ty, + val: OperandValue::Immediate(llfn) + } + }, traits::VtableObject(ref data) => { let idx = traits::get_vtable_index_of_object_method(tcx, data, method_id); OperandRef::from_rvalue_datum(