mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-23 23:34:48 +00:00
Rollup merge of #91397 - jyn514:generic-param-docs, r=wesleywiser
Emit a warning on generic parameters with doc comments Fixes https://github.com/rust-lang/rust/issues/90610
This commit is contained in:
commit
7baafb1f5e
@ -1079,6 +1079,10 @@ impl EarlyLintPass for UnusedDocComment {
|
||||
fn check_expr(&mut self, cx: &EarlyContext<'_>, expr: &ast::Expr) {
|
||||
warn_if_doc(cx, expr.span, "expressions", &expr.attrs);
|
||||
}
|
||||
|
||||
fn check_generic_param(&mut self, cx: &EarlyContext<'_>, param: &ast::GenericParam) {
|
||||
warn_if_doc(cx, param.ident.span, "generic parameters", ¶m.attrs);
|
||||
}
|
||||
}
|
||||
|
||||
declare_lint! {
|
||||
|
@ -26,4 +26,7 @@ fn doc_comment_on_expr(num: u8) -> bool {
|
||||
num == 3
|
||||
}
|
||||
|
||||
fn doc_comment_on_generic<#[doc = "x"] T>(val: T) {}
|
||||
//~^ ERROR: unused doc comment
|
||||
|
||||
fn main() {}
|
||||
|
@ -41,6 +41,14 @@ LL | num == 3
|
||||
|
|
||||
= help: use `//` for a plain comment
|
||||
|
||||
error: unused doc comment
|
||||
--> $DIR/unused-doc-comments-edge-cases.rs:29:27
|
||||
|
|
||||
LL | fn doc_comment_on_generic<#[doc = "x"] T>(val: T) {}
|
||||
| ^^^^^^^^^^^^ - rustdoc does not generate documentation for generic parameters
|
||||
|
|
||||
= help: use `//` for a plain comment
|
||||
|
||||
error[E0308]: mismatched types
|
||||
--> $DIR/unused-doc-comments-edge-cases.rs:14:9
|
||||
|
|
||||
@ -55,7 +63,7 @@ help: you might have meant to return this value
|
||||
LL | return true;
|
||||
| ++++++ +
|
||||
|
||||
error: aborting due to 5 previous errors
|
||||
error: aborting due to 6 previous errors
|
||||
|
||||
Some errors have detailed explanations: E0308, E0658.
|
||||
For more information about an error, try `rustc --explain E0308`.
|
||||
|
Loading…
Reference in New Issue
Block a user