nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-26 08:44:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #111033 - Nadrieril:Nadrieril-triagebot, r=compiler-errors

Browse Source 
Ping Nadrieril when changing exhaustiveness checking

Hi!

I don't know what the procedure is but I'd quite like to be pinged when people try to change the exhaustiveness code. It's a tricky piece of code and I'm the de facto expert on it; I'd like to be available to provide feedback to contributors who wish to change it. I occasionally look through the git history and open PRs but a triagebot ping would be much more convenient.

The message says "might have" because `check_match.rs` contains a little bit of exhaustiveness logic and a lot of other match-related checks, so this ping will have false positives.
This commit is contained in:
Matthias Krüger 2023-05-01 01:09:49 +02:00 committed by GitHub
commit 7b488f4598
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
triagebot.toml
View File

@ -367,6 +367,10 @@ cc = ["@lcnr", "@compiler-errors"]
message = "Some changes occurred in diagnostic error codes"
cc = ["@GuillaumeGomez"]
[mentions."compiler/rustc_mir_build/src/thir/pattern"]
message = "Some changes might have occurred in exhaustiveness checking"
cc = ["@Nadrieril"]
[mentions."library"]
message = """
Hey! It looks like you've submitted a new PR for the library teams!