nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-01-22 04:34:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add macro checks in src/methods.rs lints

Browse Source
This commit is contained in:
mcarton 2016-01-20 18:32:17 +01:00
parent 91ff1db5bc
commit 7a26cfc991
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/methods.rs
View File

@ -8,9 +8,9 @@ use syntax::ptr::P;
use syntax::codemap::Span;
use utils::{
snippet, span_lint, span_note_and_lint, match_path, match_type, method_chain_args,
match_trait_method, walk_ptrs_ty_depth, walk_ptrs_ty, get_trait_def_id, implements_trait,
span_lint_and_then
get_trait_def_id, implements_trait, in_external_macro, in_macro, match_path,
match_trait_method, match_type, method_chain_args, snippet, span_lint, span_lint_and_then,
span_note_and_lint, walk_ptrs_ty, walk_ptrs_ty_depth,
};
use utils::{
BTREEMAP_ENTRY_PATH, DEFAULT_TRAIT_PATH, HASHMAP_ENTRY_PATH, OPTION_PATH, RESULT_PATH,
@ -231,6 +231,10 @@ impl LintPass for MethodsPass {
impl LateLintPass for MethodsPass {
fn check_expr(&mut self, cx: &LateContext, expr: &Expr) {
if in_macro(cx, expr.span) {
return;
}
match expr.node {
ExprMethodCall(name, _, ref args) => {
// Chain calls
@ -266,6 +270,10 @@ impl LateLintPass for MethodsPass {
}
fn check_item(&mut self, cx: &LateContext, item: &Item) {
if in_external_macro(cx, item.span) {
return;
}
if let ItemImpl(_, _, _, None, ref ty, ref items) = item.node {
for implitem in items {
let name = implitem.name;