nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-04-13 20:46:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

update comments

Browse Source
This commit is contained in:
Chenguang Wang 2020-12-09 19:50:11 -08:00
parent c6f2d49ff8
commit 78c0680b3f
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
compiler/rustc_mir/src/transform/early_otherwise_branch.rs
View File

@ -283,7 +283,7 @@ impl<'a, 'tcx> Helper<'a, 'tcx> {
return None;
}
// when one place is the projection of the other, it's not safe to calculate their discriminant values sequentially.
// when the second place is a projection of the first one, it's not safe to calculate their discriminant values sequentially.
// for example, this should not be optimized:
//
// ```rust
@ -294,18 +294,17 @@ impl<'a, 'tcx> Helper<'a, 'tcx> {
// ```mir
// bb0: {
// _2 = discriminant(*_1)
// switchInt(move _2) -> [...]
// switchInt(_2) -> [...]
// }
// bb1: {
// _3 = discriminant(*(((*_1) as Some).0: &E))
// switchInt(move _3) -> [...]
// switchInt(_3) -> [...]
// }
// ```
let discr_place = discr_info.place_of_adt_discr_read;
let this_discr_place = this_bb_discr_info.place_of_adt_discr_read;
if discr_place.local == this_discr_place.local
&& (discr_place.projection.starts_with(this_discr_place.projection)
|| this_discr_place.projection.starts_with(discr_place.projection))
&& this_discr_place.projection.starts_with(discr_place.projection)
{
trace!("NO: one target is the projection of another");
return None;