nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-30 10:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not lint float fractions in mistyped_literal_suffixes (fixes #4706)

Browse Source
This commit is contained in:
FliegendeWurst 2020-10-05 12:08:57 +02:00
parent 2ed5143c0e
commit 78695bd496
No known key found for this signature in database
GPG Key ID: CA38E82B54B32A88
4 changed files with 10 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
clippy_lints/src/literal_representation.rs
View File

@ -264,13 +264,10 @@ impl LiteralDigitGrouping {
let (part, mistyped_suffixes, missing_char) = if let Some((_, exponent)) = &mut num_lit.exponent {
(exponent, &["32", "64"][..], 'f')
} else if num_lit.fraction.is_some() {
(&mut num_lit.integer, &["32", "64"][..], 'f')
} else {
num_lit
.fraction
.as_mut()
.map_or((&mut num_lit.integer, &["8", "16", "32", "64"][..], 'i'), |fraction| {
(fraction, &["32", "64"][..], 'f')
})
(&mut num_lit.integer, &["8", "16", "32", "64"][..], 'i')
};
let mut split = part.rsplit('_');

6
tests/ui/mistyped_literal_suffix.fixed
View File

@ -1,6 +1,6 @@
// run-rustfix
#![allow(dead_code, unused_variables, clippy::excessive_precision)]
#![allow(dead_code, unused_variables, clippy::excessive_precision, clippy::inconsistent_digit_grouping)]
fn main() {
let fail14 = 2_i32;
@ -12,13 +12,13 @@ fn main() {
let fail20 = 2_i8; //
let fail21 = 4_i16; //
let fail24 = 12.34_f64;
let ok24 = 12.34_64;
let fail25 = 1E2_f32;
let fail26 = 43E7_f64;
let fail27 = 243E17_f32;
#[allow(overflowing_literals)]
let fail28 = 241_251_235E723_f64;
let fail29 = 42_279.911_f32;
let ok29 = 42279.911_32;
let _ = 1.123_45E1_f32;
}

6
tests/ui/mistyped_literal_suffix.rs
View File

@ -1,6 +1,6 @@
// run-rustfix
#![allow(dead_code, unused_variables, clippy::excessive_precision)]
#![allow(dead_code, unused_variables, clippy::excessive_precision, clippy::inconsistent_digit_grouping)]
fn main() {
let fail14 = 2_32;
@ -12,13 +12,13 @@ fn main() {
let fail20 = 2__8; //
let fail21 = 4___16; //
let fail24 = 12.34_64;
let ok24 = 12.34_64;
let fail25 = 1E2_32;
let fail26 = 43E7_64;
let fail27 = 243E17_32;
#[allow(overflowing_literals)]
let fail28 = 241251235E723_64;
let fail29 = 42279.911_32;
let ok29 = 42279.911_32;
let _ = 1.12345E1_32;
}

14
tests/ui/mistyped_literal_suffix.stderr
View File

@ -36,12 +36,6 @@ error: mistyped literal suffix
LL | let fail21 = 4___16; //
| ^^^^^^ help: did you mean to write: `4_i16`
error: mistyped literal suffix
--> $DIR/mistyped_literal_suffix.rs:15:18
|
LL | let fail24 = 12.34_64;
| ^^^^^^^^ help: did you mean to write: `12.34_f64`
error: mistyped literal suffix
--> $DIR/mistyped_literal_suffix.rs:16:18
|
@ -66,17 +60,11 @@ error: mistyped literal suffix
LL | let fail28 = 241251235E723_64;
| ^^^^^^^^^^^^^^^^ help: did you mean to write: `241_251_235E723_f64`
error: mistyped literal suffix
--> $DIR/mistyped_literal_suffix.rs:21:18
|
LL | let fail29 = 42279.911_32;
| ^^^^^^^^^^^^ help: did you mean to write: `42_279.911_f32`
error: mistyped literal suffix
--> $DIR/mistyped_literal_suffix.rs:23:13
|
LL | let _ = 1.12345E1_32;
| ^^^^^^^^^^^^ help: did you mean to write: `1.123_45E1_f32`
error: aborting due to 13 previous errors
error: aborting due to 11 previous errors