nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-04-15 05:26:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Auto merge of #8809 - Alexendoo:metadata-collection-expect, r=xFrednet

Browse Source 
Ignore unfulfilled_lint_expectations in metadata collection

r? `@xFrednet`

When metadata collection is enabled the regular early/late pass registrations are skipped, which the `#[expect()]`s were no fan of: https://github.com/rust-lang/rust-clippy/runs/6356675328?check_suite_focus=true

changelog: none
This commit is contained in:
bors 2022-05-09 19:55:37 +00:00
commit 77effb7bb2
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tests/dogfood.rs
View File

@ -21,7 +21,7 @@ fn dogfood_clippy() {
// "" is the root package
for package in &["", "clippy_dev", "clippy_lints", "clippy_utils", "rustc_tools_util"] {
run_clippy_for_package(package);
run_clippy_for_package(package, &[]);
}
}
@ -38,7 +38,7 @@ fn run_metadata_collection_lint() {
// Run collection as is
std::env::set_var("ENABLE_METADATA_COLLECTION", "1");
run_clippy_for_package("clippy_lints");
run_clippy_for_package("clippy_lints", &["-A", "unfulfilled_lint_expectations"]);
// Check if cargo caching got in the way
if let Ok(file) = File::open(metadata_output_path) {
@ -61,10 +61,10 @@ fn run_metadata_collection_lint() {
.unwrap();
// Running the collection again
run_clippy_for_package("clippy_lints");
run_clippy_for_package("clippy_lints", &["-A", "unfulfilled_lint_expectations"]);
}
fn run_clippy_for_package(project: &str) {
fn run_clippy_for_package(project: &str, args: &[&str]) {
let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
let mut command = Command::new(&*test_utils::CARGO_CLIPPY_PATH);
@ -76,6 +76,7 @@ fn run_clippy_for_package(project: &str) {
.arg("--all-targets")
.arg("--all-features")
.arg("--")
.args(args)
.args(&["-D", "clippy::all"])
.args(&["-D", "clippy::pedantic"])
.arg("-Cdebuginfo=0"); // disable debuginfo to generate less data in the target dir