mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-21 22:34:05 +00:00
Fix false positive with missing_docs
and #[test]
Since #130025, the compiler don't ignore missing_docs when compiling the tests. But there is now a false positive warning for every `#[test]` For example, this code ```rust //! Crate docs fn just_a_test() {} ``` Would emit this warning when running `cargo test` ``` warning: missing documentation for a constant --> src/lib.rs:5:1 | 4 | #[test] | ------- in this procedural macro expansion 5 | fn just_a_test() {} | ^^^^^^^^^^^^^^^^^^^ ```
This commit is contained in:
parent
4c5fc2c334
commit
6eddbb704e
@ -277,6 +277,8 @@ pub(crate) fn expand_test_or_bench(
|
||||
cx.attr_nested_word(sym::cfg, sym::test, attr_sp),
|
||||
// #[rustc_test_marker = "test_case_sort_key"]
|
||||
cx.attr_name_value_str(sym::rustc_test_marker, test_path_symbol, attr_sp),
|
||||
// #[allow(missing_docs)]
|
||||
cx.attr_nested_word(sym::allow, sym::missing_docs, attr_sp),
|
||||
],
|
||||
// const $ident: test::TestDescAndFn =
|
||||
ast::ItemKind::Const(
|
||||
|
@ -12,6 +12,7 @@ extern crate std;
|
||||
extern crate test;
|
||||
#[cfg(test)]
|
||||
#[rustc_test_marker = "m_test"]
|
||||
#[allow(missing_docs)]
|
||||
pub const m_test: test::TestDescAndFn =
|
||||
test::TestDescAndFn {
|
||||
desc: test::TestDesc {
|
||||
@ -36,6 +37,7 @@ fn m_test() {}
|
||||
extern crate test;
|
||||
#[cfg(test)]
|
||||
#[rustc_test_marker = "z_test"]
|
||||
#[allow(missing_docs)]
|
||||
pub const z_test: test::TestDescAndFn =
|
||||
test::TestDescAndFn {
|
||||
desc: test::TestDesc {
|
||||
@ -61,6 +63,7 @@ fn z_test() {}
|
||||
extern crate test;
|
||||
#[cfg(test)]
|
||||
#[rustc_test_marker = "a_test"]
|
||||
#[allow(missing_docs)]
|
||||
pub const a_test: test::TestDescAndFn =
|
||||
test::TestDescAndFn {
|
||||
desc: test::TestDesc {
|
||||
|
@ -3,3 +3,6 @@
|
||||
|
||||
//@ check-pass
|
||||
//@ compile-flags: --test -Dmissing_docs
|
||||
|
||||
#[test]
|
||||
fn test() {}
|
||||
|
Loading…
Reference in New Issue
Block a user