nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-22 23:04:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #59101 - kenta7777:reduce-code-repetition, r=oli-obk

Browse Source 
Reduces Code Repetitions like `!n >> amt`

Fixes #49937 .
This PR contains defining a function which operates bit inversion and reducing bit operation like `!0u128 >> (128 - size.bits())`.
This commit is contained in:
Mazdak Farrokhzad 2019-03-13 03:33:49 +01:00 committed by GitHub
commit 6c9bdc3410
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/librustc_mir/build/matches/simplify.rs
View File

@ -19,6 +19,7 @@ use rustc::ty;
use rustc::ty::layout::{Integer, IntegerExt, Size}; use rustc::ty::layout::{Integer, IntegerExt, Size};
use syntax::attr::{SignedInt, UnsignedInt}; use syntax::attr::{SignedInt, UnsignedInt};
use rustc::hir::RangeEnd; use rustc::hir::RangeEnd;
use rustc::mir::interpret::truncate;
use std::mem; use std::mem;
@ -115,14 +116,14 @@ impl<'a, 'gcx, 'tcx> Builder<'a, 'gcx, 'tcx> {
ty::Int(ity) => { ty::Int(ity) => {
// FIXME(49937): refactor these bit manipulations into interpret. // FIXME(49937): refactor these bit manipulations into interpret.
let size = Integer::from_attr(&tcx, SignedInt(ity)).size(); let size = Integer::from_attr(&tcx, SignedInt(ity)).size();
let max = !0u128 >> (128 - size.bits()); let max = truncate(u128::max_value(), size);
let bias = 1u128 << (size.bits() - 1); let bias = 1u128 << (size.bits() - 1);
(Some((0, max, size)), bias) (Some((0, max, size)), bias)
} }
ty::Uint(uty) => { ty::Uint(uty) => {
// FIXME(49937): refactor these bit manipulations into interpret. // FIXME(49937): refactor these bit manipulations into interpret.
let size = Integer::from_attr(&tcx, UnsignedInt(uty)).size(); let size = Integer::from_attr(&tcx, UnsignedInt(uty)).size();
let max = !0u128 >> (128 - size.bits()); let max = truncate(u128::max_value(), size);
(Some((0, max, size)), 0) (Some((0, max, size)), 0)
} }
_ => (None, 0), _ => (None, 0),