nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-24 07:44:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

vscode: rename alwaysDownloadServer -> askBeforeDownload

Browse Source 
The new name seems much simpler and it doesn't limit
this config value only to downloading the server binary.
Thus we wouldn't need to create another config
properties to handle other downloads whatsoever.
Anyway, I believe (heuristically) that most of the users
would want to set "askBeforeDownload": false once
and never bother clicking on the notification again
(because otherwise there is no big point in installing rust-analyzer if it cannot install the server)
This commit is contained in:
Veetaha 2020-03-08 18:58:02 +02:00
parent 49b4e88458
commit 6bd1ff16e5
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/user/readme.adoc
View File

@ -43,7 +43,7 @@ image::https://user-images.githubusercontent.com/9021944/75067008-17502500-54ba-
> Note: to disable this notification put the following to `settings.json`
> ```json
{
"rust-analyzer.alwaysDownloadServer": true
"rust-analyzer.askBeforeDownload": false
}
```

6
editors/code/package.json
View File

@ -219,10 +219,10 @@
}
}
},
"rust-analyzer.alwaysDownloadServer": {
"rust-analyzer.askBeforeDownload": {
"type": "boolean",
"default": false,
"description": "Whether to ask before downloading the language server binary"
"default": true,
"description": "Whether to ask for permission before downloading any files from the Internet"
},
"rust-analyzer.serverPath": {
"type": [

2
editors/code/src/config.ts
View File

@ -134,7 +134,7 @@ export class Config {
file: prebuiltBinaryName,
storage: this.ctx.globalState,
tag: Config.extensionVersion,
askBeforeDownload: !(this.cfg.get("alwaysDownloadServer") as boolean),
askBeforeDownload: !(this.cfg.get("askBeforeDownload") as boolean),
repo: {
name: "rust-analyzer",
owner: "rust-analyzer",