From fa1b7f2d7865e8fd0165899f8ac2a01aca121e39 Mon Sep 17 00:00:00 2001
From: Tobias Bucher <tobiasbucher5991@gmail.com>
Date: Mon, 20 May 2024 23:17:11 +0200
Subject: [PATCH] Remove some `Path::to_str` from `rustc_codegen_llvm`
Unnecessary panic paths when there's a better option.
---
.../rustc_codegen_llvm/src/back/archive.rs | 29 +++++++++----------
1 file changed, 14 insertions(+), 15 deletions(-)
diff --git a/compiler/rustc_codegen_llvm/src/back/archive.rs b/compiler/rustc_codegen_llvm/src/back/archive.rs
index d4a3e39cef7..c304c0cbd3b 100644
--- a/compiler/rustc_codegen_llvm/src/back/archive.rs
+++ b/compiler/rustc_codegen_llvm/src/back/archive.rs
@@ -200,21 +200,20 @@ impl ArchiveBuilderBuilder for LlvmArchiveBuilderBuilder {
_ => panic!("unsupported arch {}", sess.target.arch),
};
let mut dlltool_cmd = std::process::Command::new(&dlltool);
- dlltool_cmd.args([
- "-d",
- def_file_path.to_str().unwrap(),
- "-D",
- lib_name,
- "-l",
- output_path.to_str().unwrap(),
- "-m",
- dlltool_target_arch,
- "-f",
- dlltool_target_bitness,
- "--no-leading-underscore",
- "--temp-prefix",
- temp_prefix.to_str().unwrap(),
- ]);
+ dlltool_cmd
+ .arg("-d")
+ .arg(def_file_path)
+ .arg("-D")
+ .arg(lib_name)
+ .arg("-l")
+ .arg(&output_path)
+ .arg("-m")
+ .arg(dlltool_target_arch)
+ .arg("-f")
+ .arg(dlltool_target_bitness)
+ .arg("--no-leading-underscore")
+ .arg("--temp-prefix")
+ .arg(temp_prefix);
match dlltool_cmd.output() {
Err(e) => {