nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-26 00:34:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Make it clearer that the suggestion is an alternative one

Browse Source 
`needless_pass_by_value` sometimes suggest marking the concerned type as
`Copy`. Adding a `or` before this suggestion makes it clearer that this
is not the second part of the original suggestion, but an alternative one.
This commit is contained in:
Samuel Tardieu 2024-09-12 16:31:05 +02:00
parent e039e72d85
commit 6371b308d8
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clippy_lints/src/needless_pass_by_value.rs
View File

@ -208,7 +208,7 @@ impl<'tcx> LateLintPass<'tcx> for NeedlessPassByValue {
) )
.is_ok() .is_ok()
{ {
diag.span_help(span, "consider marking this type as `Copy`"); diag.span_help(span, "or consider marking this type as `Copy`");
} }
} }
} }

2
tests/ui/crashes/needless_pass_by_value-w-late-bound.stderr
View File

@ -4,7 +4,7 @@ error: this argument is passed by value, but not consumed in the function body
LL | fn test(x: Foo<'_>) {} LL | fn test(x: Foo<'_>) {}
| ^^^^^^^ help: consider taking a reference instead: `&Foo<'_>` | ^^^^^^^ help: consider taking a reference instead: `&Foo<'_>`
| |
help: consider marking this type as `Copy` help: or consider marking this type as `Copy`
--> tests/ui/crashes/needless_pass_by_value-w-late-bound.rs:5:1 --> tests/ui/crashes/needless_pass_by_value-w-late-bound.rs:5:1
| |
LL | struct Foo<'a>(&'a [(); 100]); LL | struct Foo<'a>(&'a [(); 100]);

8
tests/ui/needless_pass_by_value.stderr
View File

@ -121,7 +121,7 @@ error: this argument is passed by value, but not consumed in the function body
LL | fn bar_copy(x: u32, y: CopyWrapper) { LL | fn bar_copy(x: u32, y: CopyWrapper) {
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper` | ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
| |
help: consider marking this type as `Copy` help: or consider marking this type as `Copy`
--> tests/ui/needless_pass_by_value.rs:141:1 --> tests/ui/needless_pass_by_value.rs:141:1
| |
LL | struct CopyWrapper(u32); LL | struct CopyWrapper(u32);
@ -133,7 +133,7 @@ error: this argument is passed by value, but not consumed in the function body
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) { LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper` | ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
| |
help: consider marking this type as `Copy` help: or consider marking this type as `Copy`
--> tests/ui/needless_pass_by_value.rs:141:1 --> tests/ui/needless_pass_by_value.rs:141:1
| |
LL | struct CopyWrapper(u32); LL | struct CopyWrapper(u32);
@ -145,7 +145,7 @@ error: this argument is passed by value, but not consumed in the function body
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) { LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper` | ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
| |
help: consider marking this type as `Copy` help: or consider marking this type as `Copy`
--> tests/ui/needless_pass_by_value.rs:141:1 --> tests/ui/needless_pass_by_value.rs:141:1
| |
LL | struct CopyWrapper(u32); LL | struct CopyWrapper(u32);
@ -157,7 +157,7 @@ error: this argument is passed by value, but not consumed in the function body
LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) { LL | fn test_destructure_copy(x: CopyWrapper, y: CopyWrapper, z: CopyWrapper) {
| ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper` | ^^^^^^^^^^^ help: consider taking a reference instead: `&CopyWrapper`
| |
help: consider marking this type as `Copy` help: or consider marking this type as `Copy`
--> tests/ui/needless_pass_by_value.rs:141:1 --> tests/ui/needless_pass_by_value.rs:141:1
| |
LL | struct CopyWrapper(u32); LL | struct CopyWrapper(u32);