nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-25 08:13:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Auto merge of #84283 - jsha:de-emphasize-attributes, r=GuillaumeGomez

Browse Source 
rustdoc: Reduce visual weight of attributes.

Followup from #83337. As part of that PR, we stopped hiding attributes behind a toggle, because most things have just zero or one attributes. However, this made clear that the current rendering of attributes emphasizes them a lot, which distracts from function signatures. This PR changes their color of attributes to be the same as the toggles, and reduces their font weight.

This also removes `#[lang]` from the list of ALLOWED_ATTRIBUTES. This attribute is an implementation detail rather than part of the public-facing documentation.

![image](https://user-images.githubusercontent.com/220205/115131061-cc407d80-9fa9-11eb-9a77-ad3f3217f391.png)

Demo at https://hoffman-andrews.com/rust/de-emph-attr/std/string/struct.String.html#method.trim
This commit is contained in:
bors 2021-04-19 07:32:55 +00:00
commit 62652865b6
5 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/librustdoc/html/render/mod.rs
View File

@ -986,7 +986,6 @@ fn render_assoc_item(
const ALLOWED_ATTRIBUTES: &[Symbol] = &[ const ALLOWED_ATTRIBUTES: &[Symbol] = &[
sym::export_name, sym::export_name,
sym::lang,
sym::link_section, sym::link_section,
sym::must_use, sym::must_use,
sym::no_mangle, sym::no_mangle,

4
src/librustdoc/html/static/rustdoc.css
View File

@ -967,6 +967,10 @@ a.test-arrow:hover{
color: inherit; color: inherit;
} }
.code-attribute {
font-weight: 300;
}
.collapse-toggle { .collapse-toggle {
font-weight: 300; font-weight: 300;
position: absolute; position: absolute;

3
src/librustdoc/html/static/themes/ayu.css
View File

@ -329,7 +329,8 @@ a.test-arrow:hover {
color: #c5c5c5; color: #c5c5c5;
} }
.toggle-label { .toggle-label,
.code-attribute {
color: #999; color: #999;
} }

3
src/librustdoc/html/static/themes/dark.css
View File

@ -274,7 +274,8 @@ a.test-arrow:hover{
background-color: #4e8bca; background-color: #4e8bca;
} }
.toggle-label { .toggle-label,
.code-attribute {
color: #999; color: #999;
} }

3
src/librustdoc/html/static/themes/light.css
View File

@ -267,7 +267,8 @@ a.test-arrow:hover{
background-color: #4e8bca; background-color: #4e8bca;
} }
.toggle-label { .toggle-label,
.code-attribute {
color: #999; color: #999;
} }