nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-01-25 22:22:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

reference notify issue

Browse Source
This commit is contained in:
Bernardo 2019-01-12 20:32:24 +01:00 committed by Aleksey Kladov
parent 76bf7498aa
commit 5f31d495bd
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
crates/ra_vfs/src/lib.rs
View File

@ -225,7 +225,7 @@ impl Vfs {
}
}
watcher::WatcherChange::Rescan => {
// TODO send Task::AddRoot?
// TODO we should reload all files
}
},
io::TaskResult::LoadChange(None) => {}

3
crates/ra_vfs/src/watcher.rs
View File

@ -86,7 +86,8 @@ impl Watcher {
pub fn shutdown(mut self) -> thread::Result<()> {
self.bomb.defuse();
drop(self.watcher);
// TODO this doesn't terminate for some reason
// TODO this doesn't terminate because of a buf in `notify`
// uncomment when https://github.com/passcod/notify/pull/170 is released
// let res = self.thread.join();
// match &res {
// Ok(()) => log::info!("... Watcher terminated with ok"),