Add Extend impls for tuples of arity 1 through 12

This commit is contained in:
Sebastian Hahn 2024-10-26 17:25:10 +02:00
parent 17f8215394
commit 59be878506

View File

@ -492,11 +492,30 @@ impl Extend<()> for () {
fn extend_one(&mut self, _item: ()) {} fn extend_one(&mut self, _item: ()) {}
} }
#[stable(feature = "extend_for_tuple", since = "1.56.0")] macro_rules! spec_tuple_impl {
impl<A, B, ExtendA, ExtendB> Extend<(A, B)> for (ExtendA, ExtendB) ( ($ty_name:ident, $var_name:ident, $extend_ty_name: ident, $trait_name:ident, $default_fn_name:ident, $cnt:tt), ) => {
spec_tuple_impl!($trait_name, $default_fn_name, #[stable(feature = "extend_for_more_tuples", since = "CURRENT_RUSTC_VERSION")] #[doc(fake_variadic)] #[doc = "This trait is implemented for tuples up to twelve items long."] => ($ty_name, $var_name, $extend_ty_name, $cnt),);
};
// Special case (A, B) as this was stabilized earlier
( ($ty_name:ident, $var_name:ident, $extend_ty_name: ident, $trait_name:ident, $default_fn_name:ident, $cnt:tt),
($ty_names:ident, $var_names:ident, $extend_ty_names: ident, $trait_names:ident, $default_fn_names:ident, $cnts:tt),) => {
spec_tuple_impl!(($ty_names, $var_names, $extend_ty_names, $trait_names, $default_fn_names, $cnts),);
spec_tuple_impl!($trait_name, $default_fn_name, #[stable(feature = "extend_for_tuple", since = "1.56.0")] => ($ty_name, $var_name, $extend_ty_name, $cnt), ($ty_names, $var_names, $extend_ty_names, $cnts),);
};
( ($ty_name:ident, $var_name:ident, $extend_ty_name: ident, $trait_name:ident, $default_fn_name:ident, $cnt:tt), $(($ty_names:ident, $var_names:ident, $extend_ty_names:ident, $trait_names:ident, $default_fn_names:ident, $cnts:tt),)*) => {
spec_tuple_impl!($(($ty_names, $var_names, $extend_ty_names, $trait_names, $default_fn_names, $cnts),)*);
spec_tuple_impl!($trait_name, $default_fn_name, #[stable(feature = "extend_for_more_tuples", since = "CURRENT_RUSTC_VERSION")] #[doc(hidden)] => ($ty_name, $var_name, $extend_ty_name, $cnt), $(($ty_names, $var_names, $extend_ty_names, $cnts),)*);
};
($trait_name:ident, $default_fn_name:ident, #[$stable:meta] $(#[$meta:meta] $(#[$doctext:meta])?)? => $(($ty_names:ident, $var_names:ident, $extend_ty_names:ident, $cnts:tt),)*) => {
$(#[$meta]
$(#[$doctext])?
)?
#[$stable]
impl<$($ty_names,)* $($extend_ty_names,)*> Extend<($($ty_names,)*)> for ($($extend_ty_names,)*)
where where
ExtendA: Extend<A>, $($extend_ty_names: Extend<$ty_names>,)*
ExtendB: Extend<B>,
{ {
/// Allows to `extend` a tuple of collections that also implement `Extend`. /// Allows to `extend` a tuple of collections that also implement `Extend`.
/// ///
@ -504,6 +523,7 @@ where
/// ///
/// # Examples /// # Examples
/// ``` /// ```
/// // Example given for a 2-tuple, but 1- through 12-tuples are supported
/// let mut tuple = (vec![0], vec![1]); /// let mut tuple = (vec![0], vec![1]);
/// tuple.extend([(2, 3), (4, 5), (6, 7)]); /// tuple.extend([(2, 3), (4, 5), (6, 7)]);
/// assert_eq!(tuple.0, [0, 2, 4, 6]); /// assert_eq!(tuple.0, [0, 2, 4, 6]);
@ -518,89 +538,79 @@ where
/// assert_eq!(b, [2, 5, 8]); /// assert_eq!(b, [2, 5, 8]);
/// assert_eq!(c, [3, 6, 9]); /// assert_eq!(c, [3, 6, 9]);
/// ``` /// ```
fn extend<T: IntoIterator<Item = (A, B)>>(&mut self, into_iter: T) { fn extend<T: IntoIterator<Item = ($($ty_names,)*)>>(&mut self, into_iter: T) {
let (a, b) = self; let ($($var_names,)*) = self;
let iter = into_iter.into_iter(); let iter = into_iter.into_iter();
SpecTupleExtend::extend(iter, a, b); $trait_name::extend(iter, $($var_names,)*);
} }
fn extend_one(&mut self, item: (A, B)) { fn extend_one(&mut self, item: ($($ty_names,)*)) {
self.0.extend_one(item.0); $(self.$cnts.extend_one(item.$cnts);)*
self.1.extend_one(item.1);
} }
fn extend_reserve(&mut self, additional: usize) { fn extend_reserve(&mut self, additional: usize) {
self.0.extend_reserve(additional); $(self.$cnts.extend_reserve(additional);)*
self.1.extend_reserve(additional);
} }
unsafe fn extend_one_unchecked(&mut self, item: (A, B)) { unsafe fn extend_one_unchecked(&mut self, item: ($($ty_names,)*)) {
// SAFETY: Those are our safety preconditions, and we correctly forward `extend_reserve`. // SAFETY: Those are our safety preconditions, and we correctly forward `extend_reserve`.
unsafe { unsafe {
self.0.extend_one_unchecked(item.0); $(self.$cnts.extend_one_unchecked(item.$cnts);)*
self.1.extend_one_unchecked(item.1);
} }
} }
} }
fn default_extend_tuple<A, B, ExtendA, ExtendB>( trait $trait_name<$($ty_names),*> {
iter: impl Iterator<Item = (A, B)>, fn extend(self, $($var_names: &mut $ty_names,)*);
a: &mut ExtendA, }
b: &mut ExtendB,
fn $default_fn_name<$($ty_names,)* $($extend_ty_names,)*>(
iter: impl Iterator<Item = ($($ty_names,)*)>,
$($var_names: &mut $extend_ty_names,)*
) where ) where
ExtendA: Extend<A>, $($extend_ty_names: Extend<$ty_names>,)*
ExtendB: Extend<B>,
{ {
fn extend<'a, A, B>( fn extend<'a, $($ty_names,)*>(
a: &'a mut impl Extend<A>, $($var_names: &'a mut impl Extend<$ty_names>,)*
b: &'a mut impl Extend<B>, ) -> impl FnMut((), ($($ty_names,)*)) + 'a {
) -> impl FnMut((), (A, B)) + 'a { #[allow(non_snake_case)]
move |(), (t, u)| { move |(), ($($extend_ty_names,)*)| {
a.extend_one(t); $($var_names.extend_one($extend_ty_names);)*
b.extend_one(u);
} }
} }
let (lower_bound, _) = iter.size_hint(); let (lower_bound, _) = iter.size_hint();
if lower_bound > 0 { if lower_bound > 0 {
a.extend_reserve(lower_bound); $($var_names.extend_reserve(lower_bound);)*
b.extend_reserve(lower_bound);
} }
iter.fold((), extend(a, b)); iter.fold((), extend($($var_names,)*));
} }
trait SpecTupleExtend<A, B> { impl<$($ty_names,)* $($extend_ty_names,)* Iter> $trait_name<$($extend_ty_names),*> for Iter
fn extend(self, a: &mut A, b: &mut B);
}
impl<A, B, ExtendA, ExtendB, Iter> SpecTupleExtend<ExtendA, ExtendB> for Iter
where where
ExtendA: Extend<A>, $($extend_ty_names: Extend<$ty_names>,)*
ExtendB: Extend<B>, Iter: Iterator<Item = ($($ty_names,)*)>,
Iter: Iterator<Item = (A, B)>,
{ {
default fn extend(self, a: &mut ExtendA, b: &mut ExtendB) { default fn extend(self, $($var_names: &mut $extend_ty_names),*) {
default_extend_tuple(self, a, b); $default_fn_name(self, $($var_names),*);
} }
} }
impl<A, B, ExtendA, ExtendB, Iter> SpecTupleExtend<ExtendA, ExtendB> for Iter impl<$($ty_names,)* $($extend_ty_names,)* Iter> $trait_name<$($extend_ty_names),*> for Iter
where where
ExtendA: Extend<A>, $($extend_ty_names: Extend<$ty_names>,)*
ExtendB: Extend<B>, Iter: TrustedLen<Item = ($($ty_names,)*)>,
Iter: TrustedLen<Item = (A, B)>,
{ {
fn extend(self, a: &mut ExtendA, b: &mut ExtendB) { fn extend(self, $($var_names: &mut $extend_ty_names,)*) {
fn extend<'a, A, B>( fn extend<'a, $($ty_names,)*>(
a: &'a mut impl Extend<A>, $($var_names: &'a mut impl Extend<$ty_names>,)*
b: &'a mut impl Extend<B>, ) -> impl FnMut((), ($($ty_names,)*)) + 'a {
) -> impl FnMut((), (A, B)) + 'a { #[allow(non_snake_case)]
// SAFETY: We reserve enough space for the `size_hint`, and the iterator is `TrustedLen` // SAFETY: We reserve enough space for the `size_hint`, and the iterator is `TrustedLen`
// so its `size_hint` is exact. // so its `size_hint` is exact.
move |(), (t, u)| unsafe { move |(), ($($extend_ty_names,)*)| unsafe {
a.extend_one_unchecked(t); $($var_names.extend_one_unchecked($extend_ty_names);)*
b.extend_one_unchecked(u);
} }
} }
@ -608,15 +618,33 @@ where
if upper_bound.is_none() { if upper_bound.is_none() {
// We cannot reserve more than `usize::MAX` items, and this is likely to go out of memory anyway. // We cannot reserve more than `usize::MAX` items, and this is likely to go out of memory anyway.
default_extend_tuple(self, a, b); $default_fn_name(self, $($var_names,)*);
return; return;
} }
if lower_bound > 0 { if lower_bound > 0 {
a.extend_reserve(lower_bound); $($var_names.extend_reserve(lower_bound);)*
b.extend_reserve(lower_bound);
} }
self.fold((), extend(a, b)); self.fold((), extend($($var_names,)*));
} }
} }
};
}
spec_tuple_impl!(
(M, m, EM, TraitM, default_extend_tuple_m, 12),
(L, l, EL, TraitL, default_extend_tuple_l, 11),
(K, k, EK, TraitK, default_extend_tuple_k, 10),
(J, j, EJ, TraitJ, default_extend_tuple_j, 9),
(I, i, EI, TraitI, default_extend_tuple_i, 8),
(H, h, EH, TraitH, default_extend_tuple_h, 7),
(G, g, EG, TraitG, default_extend_tuple_g, 6),
(F, f, EF, TraitF, default_extend_tuple_f, 5),
(E, e, EE, TraitE, default_extend_tuple_e, 4),
(D, d, ED, TraitD, default_extend_tuple_d, 3),
(C, c, EC, TraitC, default_extend_tuple_c, 2),
(B, b, EB, TraitB, default_extend_tuple_b, 1),
(A, a, EA, TraitA, default_extend_tuple_a, 0),
);