mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-01 23:12:02 +00:00
Add comment linking to closed PR for future optimizers
While optimizing these operations proved unfruitful w.r.t. improving compiler performance right now, faster versions might be needed at a later time.
This commit is contained in:
parent
297273c45b
commit
4d38f15ede
@ -654,15 +654,19 @@ impl<T: Idx> BitRelations<ChunkedBitSet<T>> for ChunkedBitSet<T> {
|
||||
|
||||
impl<T: Idx> BitRelations<HybridBitSet<T>> for ChunkedBitSet<T> {
|
||||
fn union(&mut self, other: &HybridBitSet<T>) -> bool {
|
||||
// FIXME: this is slow if `other` is dense, and could easily be
|
||||
// improved, but it hasn't been a problem in practice so far.
|
||||
// FIXME: This is slow if `other` is dense, but it hasn't been a problem
|
||||
// in practice so far.
|
||||
// If a a faster implementation of this operation is required, consider
|
||||
// reopening https://github.com/rust-lang/rust/pull/94625
|
||||
assert_eq!(self.domain_size, other.domain_size());
|
||||
sequential_update(|elem| self.insert(elem), other.iter())
|
||||
}
|
||||
|
||||
fn subtract(&mut self, other: &HybridBitSet<T>) -> bool {
|
||||
// FIXME: this is slow if `other` is dense, and could easily be
|
||||
// improved, but it hasn't been a problem in practice so far.
|
||||
// FIXME: This is slow if `other` is dense, but it hasn't been a problem
|
||||
// in practice so far.
|
||||
// If a a faster implementation of this operation is required, consider
|
||||
// reopening https://github.com/rust-lang/rust/pull/94625
|
||||
assert_eq!(self.domain_size, other.domain_size());
|
||||
sequential_update(|elem| self.remove(elem), other.iter())
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user