nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-02-21 11:23:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3238 from JoshMcguigan/excessive_precision-3180

Browse Source 
Fixes #3180, suppress excessive_precision lint for floats with no decimal part
This commit is contained in:
Philipp Krones 2018-09-29 17:46:15 +02:00 committed by GitHub
commit 4cb16e619f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clippy_lints/src/excessive_precision.rs
View File

@ -98,8 +98,9 @@ impl ExcessivePrecision {
} }
} }
/// Should we exclude the float because it has a .0 suffix /// Should we exclude the float because it has a `.0` or `.` suffix
/// Ex 1_000_000_000.0 /// Ex 1_000_000_000.0
/// Ex 1_000_000_000.
fn dot_zero_exclusion(s: &str) -> bool { fn dot_zero_exclusion(s: &str) -> bool {
if let Some(after_dec) = s.split('.').nth(1) { if let Some(after_dec) = s.split('.').nth(1) {
let mut decpart = after_dec let mut decpart = after_dec
@ -108,7 +109,8 @@ fn dot_zero_exclusion(s: &str) -> bool {
match decpart.next() { match decpart.next() {
Some('0') => decpart.count() == 0, Some('0') => decpart.count() == 0,
_ => false, Some(_) => false,
None => true,
} }
} else { } else {
false false

3
tests/ui/excessive_precision.rs
View File

@ -54,4 +54,7 @@ fn main() {
let good_bige32: f32 = 1E-10; let good_bige32: f32 = 1E-10;
let bad_bige32: f32 = 1.123_456_788_888E-10; let bad_bige32: f32 = 1.123_456_788_888E-10;
// Inferred type
let good_inferred: f32 = 1f32 * 1_000_000_000.;
} }