nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-02-25 13:24:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

missed-spans: Fix bogus check.

Browse Source 
I don't really know what it's trying to do, but forgetting about everything
you've seen before when you see whitespace followed by a semicolon doesn't look
right to me, and absolutely no tests were hitting that.

This check was introduced in 5ecdd072d6, however
it was wrong even at that point, and now rustfmt still passes that test,
regardless of macro name.

Fixes #3154.
This commit is contained in:
Emilio Cobos Álvarez 2018-10-30 03:11:14 +01:00
parent 7bf0d308f8
commit 4a82252f03
No known key found for this signature in database
GPG Key ID: 056B727BB9C1027C
3 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/missed_spans.rs
View File

@ -308,9 +308,6 @@ impl<'a> FmtVisitor<'a> {
status.line_start = i + 1;
} else if c.is_whitespace() && status.last_wspace.is_none() {
status.last_wspace = Some(i);
} else if c == ';' && status.last_wspace.is_some() {
status.line_start = i;
status.last_wspace = None;
} else {
status.last_wspace = None;
}

3
tests/source/long-use-statement-issue-3154.rs Normal file
View File

@ -0,0 +1,3 @@
// rustfmt-reorder_imports: false
pub use self :: super :: super :: super :: root::mozilla::detail::StringClassFlags as nsTStringRepr_ClassFlags ;

3
tests/target/long-use-statement-issue-3154.rs Normal file
View File

@ -0,0 +1,3 @@
// rustfmt-reorder_imports: false
pub use self :: super :: super :: super :: root::mozilla::detail::StringClassFlags as nsTStringRepr_ClassFlags ;