mirror of
https://github.com/rust-lang/rust.git
synced 2025-04-10 19:16:51 +00:00
Merge pull request #2168 from cgm616/master
Prevent linting should_implement_trait on private methods
This commit is contained in:
Oliver Schneider
GitHub
commit
4127c230f0
@ -760,15 +760,17 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
||||
if let Some(first_arg) = iter_input_pats(&sig.decl, cx.tcx.hir.body(id)).next();
|
||||
if let hir::ItemImpl(_, _, _, _, None, ref self_ty, _) = item.node;
|
||||
then {
|
||||
if cx.access_levels.is_exported(implitem.id) {
|
||||
// check missing trait implementations
|
||||
for &(method_name, n_args, self_kind, out_type, trait_name) in &TRAIT_METHODS {
|
||||
if name == method_name &&
|
||||
sig.decl.inputs.len() == n_args &&
|
||||
out_type.matches(&sig.decl.output) &&
|
||||
self_kind.matches(first_arg_ty, first_arg, self_ty, false, &implitem.generics) {
|
||||
span_lint(cx, SHOULD_IMPLEMENT_TRAIT, implitem.span, &format!(
|
||||
"defining a method called `{}` on this type; consider implementing \
|
||||
the `{}` trait or choosing a less ambiguous name", name, trait_name));
|
||||
for &(method_name, n_args, self_kind, out_type, trait_name) in &TRAIT_METHODS {
|
||||
if name == method_name &&
|
||||
sig.decl.inputs.len() == n_args &&
|
||||
out_type.matches(&sig.decl.output) &&
|
||||
self_kind.matches(first_arg_ty, first_arg, self_ty, false, &implitem.generics) {
|
||||
span_lint(cx, SHOULD_IMPLEMENT_TRAIT, implitem.span, &format!(
|
||||
"defining a method called `{}` on this type; consider implementing \
|
||||
the `{}` trait or choosing a less ambiguous name", name, trait_name));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@ -14,11 +14,14 @@ use std::iter::FromIterator;
|
||||
use std::rc::{self, Rc};
|
||||
use std::sync::{self, Arc};
|
||||
|
||||
struct T;
|
||||
pub struct T;
|
||||
|
||||
impl T {
|
||||
fn add(self, other: T) -> T { self }
|
||||
fn drop(&mut self) { }
|
||||
pub fn add(self, other: T) -> T { self }
|
||||
|
||||
pub(crate) fn drop(&mut self) { } // no error, not public interfact
|
||||
fn neg(self) -> Self { self } // no error, private function
|
||||
fn eq(&self, other: T) -> bool { true } // no error, private function
|
||||
|
||||
fn sub(&self, other: T) -> &T { self } // no error, self is a ref
|
||||
fn div(self) -> T { self } // no error, different #arguments
|
||||
|
||||
@ -1,503 +1,503 @@
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:20:25
|
||||
--> $DIR/methods.rs:20:29
|
||||
|
|
||||
20 | fn add(self, other: T) -> T { self }
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
20 | pub fn add(self, other: T) -> T { self }
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
|
||||
= note: `-D use-self` implied by `-D warnings`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:20:31
|
||||
--> $DIR/methods.rs:20:35
|
||||
|
|
||||
20 | fn add(self, other: T) -> T { self }
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
20 | pub fn add(self, other: T) -> T { self }
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:23:26
|
||||
--> $DIR/methods.rs:24:25
|
||||
|
|
||||
23 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
|
||||
24 | fn eq(&self, other: T) -> bool { true } // no error, private function
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:26:26
|
||||
|
|
||||
26 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:23:33
|
||||
--> $DIR/methods.rs:26:33
|
||||
|
|
||||
23 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
|
||||
26 | fn sub(&self, other: T) -> &T { self } // no error, self is a ref
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:24:21
|
||||
--> $DIR/methods.rs:27:21
|
||||
|
|
||||
24 | fn div(self) -> T { self } // no error, different #arguments
|
||||
27 | fn div(self) -> T { self } // no error, different #arguments
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:25:25
|
||||
--> $DIR/methods.rs:28:25
|
||||
|
|
||||
25 | fn rem(self, other: T) { } // no error, wrong return type
|
||||
28 | fn rem(self, other: T) { } // no error, wrong return type
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
|
||||
--> $DIR/methods.rs:20:5
|
||||
|
|
||||
20 | fn add(self, other: T) -> T { self }
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
20 | pub fn add(self, other: T) -> T { self }
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: `-D should-implement-trait` implied by `-D warnings`
|
||||
|
||||
error: defining a method called `drop` on this type; consider implementing the `std::ops::Drop` trait or choosing a less ambiguous name
|
||||
--> $DIR/methods.rs:21:5
|
||||
|
|
||||
21 | fn drop(&mut self) { }
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
|
||||
--> $DIR/methods.rs:28:17
|
||||
--> $DIR/methods.rs:31:17
|
||||
|
|
||||
28 | fn into_u16(&self) -> u16 { 0 }
|
||||
31 | fn into_u16(&self) -> u16 { 0 }
|
||||
| ^^^^^
|
||||
|
|
||||
= note: `-D wrong-self-convention` implied by `-D warnings`
|
||||
|
||||
error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
|
||||
--> $DIR/methods.rs:30:21
|
||||
--> $DIR/methods.rs:33:21
|
||||
|
|
||||
30 | fn to_something(self) -> u32 { 0 }
|
||||
33 | fn to_something(self) -> u32 { 0 }
|
||||
| ^^^^
|
||||
|
||||
error: methods called `new` usually take no self; consider choosing a less ambiguous name
|
||||
--> $DIR/methods.rs:32:12
|
||||
--> $DIR/methods.rs:35:12
|
||||
|
|
||||
32 | fn new(self) {}
|
||||
35 | fn new(self) {}
|
||||
| ^^^^
|
||||
|
||||
error: methods called `new` usually return `Self`
|
||||
--> $DIR/methods.rs:32:5
|
||||
--> $DIR/methods.rs:35:5
|
||||
|
|
||||
32 | fn new(self) {}
|
||||
35 | fn new(self) {}
|
||||
| ^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: `-D new-ret-no-self` implied by `-D warnings`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:76:24
|
||||
--> $DIR/methods.rs:79:24
|
||||
|
|
||||
76 | fn new() -> Option<V<T>> { None }
|
||||
79 | fn new() -> Option<V<T>> { None }
|
||||
| ^^^^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:80:19
|
||||
--> $DIR/methods.rs:83:19
|
||||
|
|
||||
80 | type Output = T;
|
||||
83 | type Output = T;
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:81:25
|
||||
--> $DIR/methods.rs:84:25
|
||||
|
|
||||
81 | fn mul(self, other: T) -> T { self } // no error, obviously
|
||||
84 | fn mul(self, other: T) -> T { self } // no error, obviously
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:81:31
|
||||
--> $DIR/methods.rs:84:31
|
||||
|
|
||||
81 | fn mul(self, other: T) -> T { self } // no error, obviously
|
||||
84 | fn mul(self, other: T) -> T { self } // no error, obviously
|
||||
| ^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
||||
--> $DIR/methods.rs:100:13
|
||||
--> $DIR/methods.rs:103:13
|
||||
|
|
||||
100 | let _ = opt.map(|x| x + 1)
|
||||
103 | let _ = opt.map(|x| x + 1)
|
||||
| _____________^
|
||||
101 | |
|
||||
102 | | .unwrap_or(0); // should lint even though this call is on a separate line
|
||||
104 | |
|
||||
105 | | .unwrap_or(0); // should lint even though this call is on a separate line
|
||||
| |____________________________^
|
||||
|
|
||||
= note: `-D option-map-unwrap-or` implied by `-D warnings`
|
||||
= note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
|
||||
|
||||
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
||||
--> $DIR/methods.rs:104:13
|
||||
--> $DIR/methods.rs:107:13
|
||||
|
|
||||
104 | let _ = opt.map(|x| {
|
||||
107 | let _ = opt.map(|x| {
|
||||
| _____________^
|
||||
105 | | x + 1
|
||||
106 | | }
|
||||
107 | | ).unwrap_or(0);
|
||||
108 | | x + 1
|
||||
109 | | }
|
||||
110 | | ).unwrap_or(0);
|
||||
| |____________________________^
|
||||
|
||||
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
|
||||
--> $DIR/methods.rs:108:13
|
||||
--> $DIR/methods.rs:111:13
|
||||
|
|
||||
108 | let _ = opt.map(|x| x + 1)
|
||||
111 | let _ = opt.map(|x| x + 1)
|
||||
| _____________^
|
||||
109 | | .unwrap_or({
|
||||
110 | | 0
|
||||
111 | | });
|
||||
112 | | .unwrap_or({
|
||||
113 | | 0
|
||||
114 | | });
|
||||
| |__________________^
|
||||
|
||||
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
||||
--> $DIR/methods.rs:113:13
|
||||
--> $DIR/methods.rs:116:13
|
||||
|
|
||||
113 | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
|
||||
116 | let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
|
||||
|
||||
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
||||
--> $DIR/methods.rs:115:13
|
||||
--> $DIR/methods.rs:118:13
|
||||
|
|
||||
115 | let _ = opt.map(|x| {
|
||||
118 | let _ = opt.map(|x| {
|
||||
| _____________^
|
||||
116 | | Some(x + 1)
|
||||
117 | | }
|
||||
118 | | ).unwrap_or(None);
|
||||
119 | | Some(x + 1)
|
||||
120 | | }
|
||||
121 | | ).unwrap_or(None);
|
||||
| |_____________________^
|
||||
|
||||
error: called `map(f).unwrap_or(None)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
||||
--> $DIR/methods.rs:119:13
|
||||
--> $DIR/methods.rs:122:13
|
||||
|
|
||||
119 | let _ = opt
|
||||
122 | let _ = opt
|
||||
| _____________^
|
||||
120 | | .map(|x| Some(x + 1))
|
||||
121 | | .unwrap_or(None);
|
||||
123 | | .map(|x| Some(x + 1))
|
||||
124 | | .unwrap_or(None);
|
||||
| |________________________^
|
||||
|
|
||||
= note: replace `map(|x| Some(x + 1)).unwrap_or(None)` with `and_then(|x| Some(x + 1))`
|
||||
|
||||
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
||||
--> $DIR/methods.rs:127:13
|
||||
--> $DIR/methods.rs:130:13
|
||||
|
|
||||
127 | let _ = opt.map(|x| x + 1)
|
||||
130 | let _ = opt.map(|x| x + 1)
|
||||
| _____________^
|
||||
128 | |
|
||||
129 | | .unwrap_or_else(|| 0); // should lint even though this call is on a separate line
|
||||
131 | |
|
||||
132 | | .unwrap_or_else(|| 0); // should lint even though this call is on a separate line
|
||||
| |____________________________________^
|
||||
|
|
||||
= note: `-D option-map-unwrap-or-else` implied by `-D warnings`
|
||||
= note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
|
||||
|
||||
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
||||
--> $DIR/methods.rs:131:13
|
||||
--> $DIR/methods.rs:134:13
|
||||
|
|
||||
131 | let _ = opt.map(|x| {
|
||||
134 | let _ = opt.map(|x| {
|
||||
| _____________^
|
||||
132 | | x + 1
|
||||
133 | | }
|
||||
134 | | ).unwrap_or_else(|| 0);
|
||||
135 | | x + 1
|
||||
136 | | }
|
||||
137 | | ).unwrap_or_else(|| 0);
|
||||
| |____________________________________^
|
||||
|
||||
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
|
||||
--> $DIR/methods.rs:135:13
|
||||
--> $DIR/methods.rs:138:13
|
||||
|
|
||||
135 | let _ = opt.map(|x| x + 1)
|
||||
138 | let _ = opt.map(|x| x + 1)
|
||||
| _____________^
|
||||
136 | | .unwrap_or_else(||
|
||||
137 | | 0
|
||||
138 | | );
|
||||
139 | | .unwrap_or_else(||
|
||||
140 | | 0
|
||||
141 | | );
|
||||
| |_________________^
|
||||
|
||||
error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
||||
--> $DIR/methods.rs:144:13
|
||||
--> $DIR/methods.rs:147:13
|
||||
|
|
||||
144 | let _ = opt.map_or(None, |x| Some(x + 1));
|
||||
147 | let _ = opt.map_or(None, |x| Some(x + 1));
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `opt.and_then(|x| Some(x + 1))`
|
||||
|
|
||||
= note: `-D option-map-or-none` implied by `-D warnings`
|
||||
|
||||
error: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
|
||||
--> $DIR/methods.rs:146:13
|
||||
--> $DIR/methods.rs:149:13
|
||||
|
|
||||
146 | let _ = opt.map_or(None, |x| {
|
||||
149 | let _ = opt.map_or(None, |x| {
|
||||
| _____________^
|
||||
147 | | Some(x + 1)
|
||||
148 | | }
|
||||
149 | | );
|
||||
150 | | Some(x + 1)
|
||||
151 | | }
|
||||
152 | | );
|
||||
| |_________________^
|
||||
|
|
||||
help: try using and_then instead
|
||||
|
|
||||
146 | let _ = opt.and_then(|x| {
|
||||
147 | Some(x + 1)
|
||||
148 | });
|
||||
149 | let _ = opt.and_then(|x| {
|
||||
150 | Some(x + 1)
|
||||
151 | });
|
||||
|
|
||||
|
||||
error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
|
||||
--> $DIR/methods.rs:159:13
|
||||
--> $DIR/methods.rs:162:13
|
||||
|
|
||||
159 | let _ = res.map(|x| x + 1)
|
||||
162 | let _ = res.map(|x| x + 1)
|
||||
| _____________^
|
||||
160 | |
|
||||
161 | | .unwrap_or_else(|e| 0); // should lint even though this call is on a separate line
|
||||
163 | |
|
||||
164 | | .unwrap_or_else(|e| 0); // should lint even though this call is on a separate line
|
||||
| |_____________________________________^
|
||||
|
|
||||
= note: `-D result-map-unwrap-or-else` implied by `-D warnings`
|
||||
= note: replace `map(|x| x + 1).unwrap_or_else(|e| 0)` with `ok().map_or_else(|e| 0, |x| x + 1)`
|
||||
|
||||
error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
|
||||
--> $DIR/methods.rs:163:13
|
||||
--> $DIR/methods.rs:166:13
|
||||
|
|
||||
163 | let _ = res.map(|x| {
|
||||
166 | let _ = res.map(|x| {
|
||||
| _____________^
|
||||
164 | | x + 1
|
||||
165 | | }
|
||||
166 | | ).unwrap_or_else(|e| 0);
|
||||
167 | | x + 1
|
||||
168 | | }
|
||||
169 | | ).unwrap_or_else(|e| 0);
|
||||
| |_____________________________________^
|
||||
|
||||
error: called `map(f).unwrap_or_else(g)` on a Result value. This can be done more directly by calling `ok().map_or_else(g, f)` instead
|
||||
--> $DIR/methods.rs:167:13
|
||||
--> $DIR/methods.rs:170:13
|
||||
|
|
||||
167 | let _ = res.map(|x| x + 1)
|
||||
170 | let _ = res.map(|x| x + 1)
|
||||
| _____________^
|
||||
168 | | .unwrap_or_else(|e|
|
||||
169 | | 0
|
||||
170 | | );
|
||||
171 | | .unwrap_or_else(|e|
|
||||
172 | | 0
|
||||
173 | | );
|
||||
| |_________________^
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:196:24
|
||||
--> $DIR/methods.rs:199:24
|
||||
|
|
||||
196 | fn filter(self) -> IteratorFalsePositives {
|
||||
199 | fn filter(self) -> IteratorFalsePositives {
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:200:22
|
||||
--> $DIR/methods.rs:203:22
|
||||
|
|
||||
200 | fn next(self) -> IteratorFalsePositives {
|
||||
203 | fn next(self) -> IteratorFalsePositives {
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:220:32
|
||||
--> $DIR/methods.rs:223:32
|
||||
|
|
||||
220 | fn skip(self, _: usize) -> IteratorFalsePositives {
|
||||
223 | fn skip(self, _: usize) -> IteratorFalsePositives {
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
||||
--> $DIR/methods.rs:230:13
|
||||
--> $DIR/methods.rs:233:13
|
||||
|
|
||||
230 | let _ = v.iter().filter(|&x| *x < 0).next();
|
||||
233 | let _ = v.iter().filter(|&x| *x < 0).next();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: `-D filter-next` implied by `-D warnings`
|
||||
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
|
||||
|
||||
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
|
||||
--> $DIR/methods.rs:233:13
|
||||
--> $DIR/methods.rs:236:13
|
||||
|
|
||||
233 | let _ = v.iter().filter(|&x| {
|
||||
236 | let _ = v.iter().filter(|&x| {
|
||||
| _____________^
|
||||
234 | | *x < 0
|
||||
235 | | }
|
||||
236 | | ).next();
|
||||
237 | | *x < 0
|
||||
238 | | }
|
||||
239 | | ).next();
|
||||
| |___________________________^
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
||||
--> $DIR/methods.rs:248:13
|
||||
--> $DIR/methods.rs:251:13
|
||||
|
|
||||
248 | let _ = v.iter().find(|&x| *x < 0).is_some();
|
||||
251 | let _ = v.iter().find(|&x| *x < 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: `-D search-is-some` implied by `-D warnings`
|
||||
= note: replace `find(|&x| *x < 0).is_some()` with `any(|&x| *x < 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
|
||||
--> $DIR/methods.rs:251:13
|
||||
--> $DIR/methods.rs:254:13
|
||||
|
|
||||
251 | let _ = v.iter().find(|&x| {
|
||||
254 | let _ = v.iter().find(|&x| {
|
||||
| _____________^
|
||||
252 | | *x < 0
|
||||
253 | | }
|
||||
254 | | ).is_some();
|
||||
255 | | *x < 0
|
||||
256 | | }
|
||||
257 | | ).is_some();
|
||||
| |______________________________^
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
||||
--> $DIR/methods.rs:257:13
|
||||
--> $DIR/methods.rs:260:13
|
||||
|
|
||||
257 | let _ = v.iter().position(|&x| x < 0).is_some();
|
||||
260 | let _ = v.iter().position(|&x| x < 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
|
||||
--> $DIR/methods.rs:260:13
|
||||
--> $DIR/methods.rs:263:13
|
||||
|
|
||||
260 | let _ = v.iter().position(|&x| {
|
||||
263 | let _ = v.iter().position(|&x| {
|
||||
| _____________^
|
||||
261 | | x < 0
|
||||
262 | | }
|
||||
263 | | ).is_some();
|
||||
264 | | x < 0
|
||||
265 | | }
|
||||
266 | | ).is_some();
|
||||
| |______________________________^
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
||||
--> $DIR/methods.rs:266:13
|
||||
--> $DIR/methods.rs:269:13
|
||||
|
|
||||
266 | let _ = v.iter().rposition(|&x| x < 0).is_some();
|
||||
269 | let _ = v.iter().rposition(|&x| x < 0).is_some();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
|
||||
|
||||
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
|
||||
--> $DIR/methods.rs:269:13
|
||||
--> $DIR/methods.rs:272:13
|
||||
|
|
||||
269 | let _ = v.iter().rposition(|&x| {
|
||||
272 | let _ = v.iter().rposition(|&x| {
|
||||
| _____________^
|
||||
270 | | x < 0
|
||||
271 | | }
|
||||
272 | | ).is_some();
|
||||
273 | | x < 0
|
||||
274 | | }
|
||||
275 | | ).is_some();
|
||||
| |______________________________^
|
||||
|
||||
error: unnecessary structure name repetition
|
||||
--> $DIR/methods.rs:286:21
|
||||
--> $DIR/methods.rs:289:21
|
||||
|
|
||||
286 | fn new() -> Foo { Foo }
|
||||
289 | fn new() -> Foo { Foo }
|
||||
| ^^^ help: use the applicable keyword: `Self`
|
||||
|
||||
error: use of `unwrap_or` followed by a function call
|
||||
--> $DIR/methods.rs:304:5
|
||||
--> $DIR/methods.rs:307:5
|
||||
|
|
||||
304 | with_constructor.unwrap_or(make());
|
||||
307 | with_constructor.unwrap_or(make());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_constructor.unwrap_or_else(make)`
|
||||
|
|
||||
= note: `-D or-fun-call` implied by `-D warnings`
|
||||
|
||||
error: use of `unwrap_or` followed by a call to `new`
|
||||
--> $DIR/methods.rs:307:5
|
||||
|
|
||||
307 | with_new.unwrap_or(Vec::new());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
|
||||
|
||||
error: use of `unwrap_or` followed by a function call
|
||||
--> $DIR/methods.rs:310:5
|
||||
|
|
||||
310 | with_const_args.unwrap_or(Vec::with_capacity(12));
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_const_args.unwrap_or_else(|| Vec::with_capacity(12))`
|
||||
310 | with_new.unwrap_or(Vec::new());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_new.unwrap_or_default()`
|
||||
|
||||
error: use of `unwrap_or` followed by a function call
|
||||
--> $DIR/methods.rs:313:5
|
||||
|
|
||||
313 | with_err.unwrap_or(make());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err.unwrap_or_else(|_| make())`
|
||||
313 | with_const_args.unwrap_or(Vec::with_capacity(12));
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_const_args.unwrap_or_else(|| Vec::with_capacity(12))`
|
||||
|
||||
error: use of `unwrap_or` followed by a function call
|
||||
--> $DIR/methods.rs:316:5
|
||||
|
|
||||
316 | with_err_args.unwrap_or(Vec::with_capacity(12));
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err_args.unwrap_or_else(|_| Vec::with_capacity(12))`
|
||||
316 | with_err.unwrap_or(make());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err.unwrap_or_else(|_| make())`
|
||||
|
||||
error: use of `unwrap_or` followed by a call to `default`
|
||||
error: use of `unwrap_or` followed by a function call
|
||||
--> $DIR/methods.rs:319:5
|
||||
|
|
||||
319 | with_default_trait.unwrap_or(Default::default());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
|
||||
319 | with_err_args.unwrap_or(Vec::with_capacity(12));
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_err_args.unwrap_or_else(|_| Vec::with_capacity(12))`
|
||||
|
||||
error: use of `unwrap_or` followed by a call to `default`
|
||||
--> $DIR/methods.rs:322:5
|
||||
|
|
||||
322 | with_default_type.unwrap_or(u64::default());
|
||||
322 | with_default_trait.unwrap_or(Default::default());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_trait.unwrap_or_default()`
|
||||
|
||||
error: use of `unwrap_or` followed by a call to `default`
|
||||
--> $DIR/methods.rs:325:5
|
||||
|
|
||||
325 | with_default_type.unwrap_or(u64::default());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_default_type.unwrap_or_default()`
|
||||
|
||||
error: use of `unwrap_or` followed by a function call
|
||||
--> $DIR/methods.rs:325:5
|
||||
--> $DIR/methods.rs:328:5
|
||||
|
|
||||
325 | with_vec.unwrap_or(vec![]);
|
||||
328 | with_vec.unwrap_or(vec![]);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `with_vec.unwrap_or_else(|| < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
|
||||
|
||||
error: use of `unwrap_or` followed by a function call
|
||||
--> $DIR/methods.rs:330:5
|
||||
|
|
||||
330 | without_default.unwrap_or(Foo::new());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `without_default.unwrap_or_else(Foo::new)`
|
||||
|
||||
error: use of `or_insert` followed by a function call
|
||||
--> $DIR/methods.rs:333:5
|
||||
|
|
||||
333 | map.entry(42).or_insert(String::new());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `map.entry(42).or_insert_with(String::new)`
|
||||
333 | without_default.unwrap_or(Foo::new());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `without_default.unwrap_or_else(Foo::new)`
|
||||
|
||||
error: use of `or_insert` followed by a function call
|
||||
--> $DIR/methods.rs:336:5
|
||||
|
|
||||
336 | btree.entry(42).or_insert(String::new());
|
||||
336 | map.entry(42).or_insert(String::new());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `map.entry(42).or_insert_with(String::new)`
|
||||
|
||||
error: use of `or_insert` followed by a function call
|
||||
--> $DIR/methods.rs:339:5
|
||||
|
|
||||
339 | btree.entry(42).or_insert(String::new());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `btree.entry(42).or_insert_with(String::new)`
|
||||
|
||||
error: use of `unwrap_or` followed by a function call
|
||||
--> $DIR/methods.rs:339:13
|
||||
--> $DIR/methods.rs:342:13
|
||||
|
|
||||
339 | let _ = stringy.unwrap_or("".to_owned());
|
||||
342 | let _ = stringy.unwrap_or("".to_owned());
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `stringy.unwrap_or_else(|| "".to_owned())`
|
||||
|
||||
error: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
|
||||
--> $DIR/methods.rs:350:23
|
||||
--> $DIR/methods.rs:353:23
|
||||
|
|
||||
350 | let bad_vec = some_vec.iter().nth(3);
|
||||
353 | let bad_vec = some_vec.iter().nth(3);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: `-D iter-nth` implied by `-D warnings`
|
||||
|
||||
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
|
||||
--> $DIR/methods.rs:351:26
|
||||
--> $DIR/methods.rs:354:26
|
||||
|
|
||||
351 | let bad_slice = &some_vec[..].iter().nth(3);
|
||||
354 | let bad_slice = &some_vec[..].iter().nth(3);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
|
||||
--> $DIR/methods.rs:352:31
|
||||
--> $DIR/methods.rs:355:31
|
||||
|
|
||||
352 | let bad_boxed_slice = boxed_slice.iter().nth(3);
|
||||
355 | let bad_boxed_slice = boxed_slice.iter().nth(3);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
|
||||
--> $DIR/methods.rs:353:29
|
||||
--> $DIR/methods.rs:356:29
|
||||
|
|
||||
353 | let bad_vec_deque = some_vec_deque.iter().nth(3);
|
||||
356 | let bad_vec_deque = some_vec_deque.iter().nth(3);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
|
||||
--> $DIR/methods.rs:358:23
|
||||
--> $DIR/methods.rs:361:23
|
||||
|
|
||||
358 | let bad_vec = some_vec.iter_mut().nth(3);
|
||||
361 | let bad_vec = some_vec.iter_mut().nth(3);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
|
||||
--> $DIR/methods.rs:361:26
|
||||
--> $DIR/methods.rs:364:26
|
||||
|
|
||||
361 | let bad_slice = &some_vec[..].iter_mut().nth(3);
|
||||
364 | let bad_slice = &some_vec[..].iter_mut().nth(3);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
|
||||
--> $DIR/methods.rs:364:29
|
||||
--> $DIR/methods.rs:367:29
|
||||
|
|
||||
364 | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
|
||||
367 | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
||||
--> $DIR/methods.rs:376:13
|
||||
--> $DIR/methods.rs:379:13
|
||||
|
|
||||
376 | let _ = some_vec.iter().skip(42).next();
|
||||
379 | let _ = some_vec.iter().skip(42).next();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
|
||||
= note: `-D iter-skip-next` implied by `-D warnings`
|
||||
|
||||
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
||||
--> $DIR/methods.rs:377:13
|
||||
--> $DIR/methods.rs:380:13
|
||||
|
|
||||
377 | let _ = some_vec.iter().cycle().skip(42).next();
|
||||
380 | let _ = some_vec.iter().cycle().skip(42).next();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
||||
--> $DIR/methods.rs:378:13
|
||||
--> $DIR/methods.rs:381:13
|
||||
|
|
||||
378 | let _ = (1..10).skip(10).next();
|
||||
381 | let _ = (1..10).skip(10).next();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
|
||||
--> $DIR/methods.rs:379:14
|
||||
--> $DIR/methods.rs:382:14
|
||||
|
|
||||
379 | let _ = &some_vec[..].iter().skip(3).next();
|
||||
382 | let _ = &some_vec[..].iter().skip(3).next();
|
||||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
|
||||
--> $DIR/methods.rs:388:13
|
||||
--> $DIR/methods.rs:391:13
|
||||
|
|
||||
388 | let _ = opt.unwrap();
|
||||
391 | let _ = opt.unwrap();
|
||||
| ^^^^^^^^^^^^
|
||||
|
|
||||
= note: `-D option-unwrap-used` implied by `-D warnings`
|
||||
|
||||
Loading…
Reference in New Issue
Block a user