nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-26 00:34:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rollup merge of #105978 - jyn514:unused_proc_macro_decl, r=tmiasko

Browse Source 
Mark `proc_macro_decls_static` as always used

This would have avoided a bug in https://github.com/rust-lang/rust/pull/104860.

In practice this shouldn't matter since nothing uses the query other than the `dead_code` lint, but this isn't documented as an internal-only query so it seems nice for it to be accurate. I think for `dead_code` it doesn't matter because the relevant code is generated by `rustc_builtin_macros` and isn't linted.

I think `@tmiasko` or `@bjorn3` would be a good reviewer?

r? `@tmiasko`
This commit is contained in:
Matthias Krüger 2022-12-23 01:17:50 +01:00 committed by GitHub
commit 3e58de240c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
compiler/rustc_builtin_macros/src/proc_macro_harness.rs
View File

@ -262,6 +262,7 @@ impl<'a> Visitor<'a> for CollectProcMacros<'a> {
// use proc_macro::bridge::client::ProcMacro; // use proc_macro::bridge::client::ProcMacro;
// //
// #[rustc_proc_macro_decls] // #[rustc_proc_macro_decls]
// #[used]
// #[allow(deprecated)] // #[allow(deprecated)]
// static DECLS: &[ProcMacro] = &[ // static DECLS: &[ProcMacro] = &[
// ProcMacro::custom_derive($name_trait1, &[], ::$name1); // ProcMacro::custom_derive($name_trait1, &[], ::$name1);
@ -364,6 +365,7 @@ fn mk_decls(cx: &mut ExtCtxt<'_>, macros: &[ProcMacro]) -> P<ast::Item> {
) )
.map(|mut i| { .map(|mut i| {
i.attrs.push(cx.attr_word(sym::rustc_proc_macro_decls, span)); i.attrs.push(cx.attr_word(sym::rustc_proc_macro_decls, span));
i.attrs.push(cx.attr_word(sym::used, span));
i.attrs.push(cx.attr_nested_word(sym::allow, sym::deprecated, span)); i.attrs.push(cx.attr_nested_word(sym::allow, sym::deprecated, span));
i i
}); });

1
src/test/ui/proc-macro/quote-debug.stdout
View File

@ -42,6 +42,7 @@ const _: () =
{ {
extern crate proc_macro; extern crate proc_macro;
#[rustc_proc_macro_decls] #[rustc_proc_macro_decls]
#[used]
#[allow(deprecated)] #[allow(deprecated)]
static _DECLS: &[proc_macro::bridge::client::ProcMacro] = &[]; static _DECLS: &[proc_macro::bridge::client::ProcMacro] = &[];
}; };