nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2025-04-28 02:57:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

codegen_llvm_back: use mem::replace instead of swap where more concise

Browse Source
This commit is contained in:
ljedrz 2018-10-06 11:51:14 +02:00
parent ed5802c4d1
commit 3968ada006
1 changed files with 5 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/librustc_codegen_utils/linker.rs
View File

@ -456,9 +456,8 @@ impl<'a> Linker for GccLinker<'a> {
fn finalize(&mut self) -> Command {
self.hint_dynamic(); // Reset to default before returning the composed command line.
let mut cmd = Command::new("");
::std::mem::swap(&mut cmd, &mut self.cmd);
cmd
::std::mem::replace(&mut self.cmd, Command::new(""))
}
fn group_start(&mut self) {
@ -710,9 +709,7 @@ impl<'a> Linker for MsvcLinker<'a> {
}
fn finalize(&mut self) -> Command {
let mut cmd = Command::new("");
::std::mem::swap(&mut cmd, &mut self.cmd);
cmd
::std::mem::replace(&mut self.cmd, Command::new(""))
}
// MSVC doesn't need group indicators
@ -880,9 +877,7 @@ impl<'a> Linker for EmLinker<'a> {
}
fn finalize(&mut self) -> Command {
let mut cmd = Command::new("");
::std::mem::swap(&mut cmd, &mut self.cmd);
cmd
::std::mem::replace(&mut self.cmd, Command::new(""))
}
// Appears not necessary on Emscripten
@ -1080,9 +1075,7 @@ impl<'a> Linker for WasmLd<'a> {
// indicative of bugs, let's prevent them.
self.cmd.arg("--fatal-warnings");
let mut cmd = Command::new("");
::std::mem::swap(&mut cmd, &mut self.cmd);
cmd
::std::mem::replace(&mut self.cmd, Command::new(""))
}
// Not needed for now with LLD