nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-30 02:33:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not consider synthesized RPITITs on missing items checks

Browse Source
This commit is contained in:
Santiago Pastorino 2023-03-20 18:19:20 -03:00
parent febd59e122
commit 364a5d4b54
No known key found for this signature in database
GPG Key ID: 8131A24E0C79EFAF
4 changed files with 31 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
compiler/rustc_hir_analysis/src/check/mod.rs
View File

@ -202,8 +202,11 @@ fn missing_items_err(
missing_items: &[ty::AssocItem], missing_items: &[ty::AssocItem],
full_impl_span: Span, full_impl_span: Span,
) { ) {
let missing_items =
missing_items.iter().filter(|trait_item| tcx.opt_rpitit_info(trait_item.def_id).is_none());
let missing_items_msg = missing_items let missing_items_msg = missing_items
.iter() .clone()
.map(|trait_item| trait_item.name.to_string()) .map(|trait_item| trait_item.name.to_string())
.collect::<Vec<_>>() .collect::<Vec<_>>()
.join("`, `"); .join("`, `");

4
tests/ui/impl-trait/in-trait/dont-project-to-rpitit-with-no-value.stderr → tests/ui/impl-trait/in-trait/dont-project-to-rpitit-with-no-value.current.stderr
View File

@ -1,5 +1,5 @@
warning: the feature `return_position_impl_trait_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes warning: the feature `return_position_impl_trait_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
--> $DIR/dont-project-to-rpitit-with-no-value.rs:1:12 --> $DIR/dont-project-to-rpitit-with-no-value.rs:4:12
| |
LL | #![feature(return_position_impl_trait_in_trait)] LL | #![feature(return_position_impl_trait_in_trait)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
@ -8,7 +8,7 @@ LL | #![feature(return_position_impl_trait_in_trait)]
= note: `#[warn(incomplete_features)]` on by default = note: `#[warn(incomplete_features)]` on by default
error[E0046]: not all trait items implemented, missing: `foo` error[E0046]: not all trait items implemented, missing: `foo`
--> $DIR/dont-project-to-rpitit-with-no-value.rs:9:1 --> $DIR/dont-project-to-rpitit-with-no-value.rs:12:1
| |
LL | fn foo(&self) -> impl Sized; LL | fn foo(&self) -> impl Sized;
| ---------------------------- `foo` from trait | ---------------------------- `foo` from trait

21
tests/ui/impl-trait/in-trait/dont-project-to-rpitit-with-no-value.next.stderr Normal file
View File

@ -0,0 +1,21 @@
warning: the feature `return_position_impl_trait_in_trait` is incomplete and may not be safe to use and/or cause compiler crashes
--> $DIR/dont-project-to-rpitit-with-no-value.rs:4:12
|
LL | #![feature(return_position_impl_trait_in_trait)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: see issue #91611 <https://github.com/rust-lang/rust/issues/91611> for more information
= note: `#[warn(incomplete_features)]` on by default
error[E0046]: not all trait items implemented, missing: `foo`
--> $DIR/dont-project-to-rpitit-with-no-value.rs:12:1
|
LL | fn foo(&self) -> impl Sized;
| ---------------------------- `foo` from trait
...
LL | impl MyTrait for i32 {
| ^^^^^^^^^^^^^^^^^^^^ missing `foo` in implementation
error: aborting due to previous error; 1 warning emitted
For more information about this error, try `rustc --explain E0046`.

5
tests/ui/impl-trait/in-trait/dont-project-to-rpitit-with-no-value.rs
View File

@ -1,3 +1,6 @@
// [next] compile-flags: -Zlower-impl-trait-in-trait-to-assoc-ty
// revisions: current next
#![feature(return_position_impl_trait_in_trait)] #![feature(return_position_impl_trait_in_trait)]
//~^ WARN the feature `return_position_impl_trait_in_trait` is incomplete //~^ WARN the feature `return_position_impl_trait_in_trait` is incomplete
@ -7,7 +10,7 @@ trait MyTrait {
} }
impl MyTrait for i32 { impl MyTrait for i32 {
//~^ ERROR not all trait items implemented, missing: `foo` //~^ ERROR not all trait items implemented, missing: `foo`
fn bar(&self) -> impl Sized { fn bar(&self) -> impl Sized {
self.foo() self.foo()
} }