nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-22 23:04:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: re-enable dump-ice-to-disk for Windows

Browse Source 
This test was previously flakey on `i686-mingw`, but since some
modifications I could no longer make it fail on `i686-mingw`.

See <https://github.com/rust-lang/rust/pull/128958> for multiple try
job runs.
This commit is contained in:
许杰友 Jieyou Xu (Joe) 2024-08-15 05:13:05 +00:00
parent 13a52890dd
commit 35785ef39f
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
tests/run-make/dump-ice-to-disk/rmake.rs
View File

@ -14,11 +14,14 @@
//! that `RUSTC_ICE_PATH` takes precedence and no ICE dump is emitted under `METRICS_PATH`.
//!
//! See <https://github.com/rust-lang/rust/pull/108714>.
//@ ignore-windows
// FIXME(#128911): @jieyouxu: This test is sometimes for whatever forsaken reason flakey in
// `i686-mingw`, and I cannot reproduce it locally. The error messages upon assertion failure in
// this test is intentionally extremely verbose to aid debugging that issue.
//!
//! # Test history
//!
//! - The previous rmake.rs iteration of this test was flakey for unknown reason on `i686-mingw`
//! *specifically*, so assertion failures in this test was made extremely verbose to help
//! diagnose why the ICE messages was different *specifically* on `i686-mingw`.
//! - An attempt is made to re-enable this test on `i686-mingw` (by removing `ignore-windows`). If
//! this test is still flakey, please restore the `ignore-windows` directive.
use std::cell::OnceCell;
use std::path::{Path, PathBuf};