nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-25 08:13:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

num::NonZero::get can be 1 transmute instead of 3

Browse Source
This commit is contained in:
Scott McMurray 2024-03-27 10:25:56 -07:00
parent 548e14b439
commit 336ff42367
1 changed files with 14 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
library/core/src/num/nonzero.rs
View File

@ -20,7 +20,15 @@ use super::{IntErrorKind, ParseIntError};
/// ///
/// # Safety /// # Safety
/// ///
/// Types implementing this trait must be primitves that are valid when zeroed. /// Types implementing this trait must be primitives that are valid when zeroed.
///
/// The associated `Self::NonZeroInner` type must have the same size+align as `Self`,
/// but with a niche and bit validity making it so the following `transmutes` are sound:
///
/// - `Self::NonZeroInner` to `Option<Self::NonZeroInner>`
/// - `Option<Self::NonZeroInner>` to `Self`
///
/// (And, consequently, `Self::NonZeroInner` to `Self`.)
#[unstable( #[unstable(
feature = "nonzero_internals", feature = "nonzero_internals",
reason = "implementation detail which may disappear or be replaced at any time", reason = "implementation detail which may disappear or be replaced at any time",
@ -434,17 +442,11 @@ where
// of some not-inlined function, LLVM don't have range metadata // of some not-inlined function, LLVM don't have range metadata
// to understand that the value cannot be zero. // to understand that the value cannot be zero.
// //
// SAFETY: `Self` is guaranteed to have the same layout as `Option<Self>`. // For now, using the transmute `assume`s the range at runtime.
match unsafe { intrinsics::transmute_unchecked(self) } { //
None => { // SAFETY: `ZeroablePrimitive` guarantees that the size and bit validity
// SAFETY: `NonZero` is guaranteed to only contain non-zero values, so this is unreachable. // of `.0` is such that this transmute is sound.
unsafe { intrinsics::unreachable() } unsafe { intrinsics::transmute_unchecked(self) }
}
Some(Self(inner)) => {
// SAFETY: `T::NonZeroInner` is guaranteed to have the same layout as `T`.
unsafe { intrinsics::transmute_unchecked(inner) }
}
}
} }
} }