nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-10-30 14:01:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Noah Lev 2022-08-07 21:16:47 -07:00
parent 1f75142c8c
commit 31a051870b
2 changed files with 30 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
compiler/rustc_typeck/src/check/fn_ctxt/mod.rs
View File

@ -26,8 +26,17 @@ use rustc_trait_selection::traits::{ObligationCause, ObligationCauseCode};
use std::cell::{Cell, RefCell}; use std::cell::{Cell, RefCell};
use std::ops::Deref; use std::ops::Deref;
/// The `FnCtxt` stores type-checking context needed to type-check function bodies, /// The `FnCtxt` stores type-checking context needed to type-check bodies of
/// in contrast to [`ItemCtxt`], which is used to type-check item *signatures*. /// functions, closures, and `const`s, including performing type inference
/// with [`InferCtxt`].
///
/// This is in contrast to [`ItemCtxt`], which is used to type-check item *signatures*
/// and thus does not perform type inference.
///
/// See [`ItemCtxt`]'s docs for more.
///
/// [`ItemCtxt`]: crate::collect::ItemCtxt
/// [`InferCtxt`]: infer::InferCtxt
pub struct FnCtxt<'a, 'tcx> { pub struct FnCtxt<'a, 'tcx> {
pub(super) body_id: hir::HirId, pub(super) body_id: hir::HirId,

23
compiler/rustc_typeck/src/collect.rs
View File

@ -94,12 +94,27 @@ pub fn provide(providers: &mut Providers) {
/////////////////////////////////////////////////////////////////////////// ///////////////////////////////////////////////////////////////////////////
/// Context specific to some particular item. This is what implements /// Context specific to some particular item. This is what implements
/// `AstConv`. /// [`AstConv`].
/// ///
/// `ItemCtxt` is primarily used to type-check item signatures, in contrast to [`FnCtxt`], /// # `ItemCtxt` vs `FnCtxt`
/// which is used to type-check function bodies.
/// ///
/// It has information about the predicates that are defined /// `ItemCtxt` is primarily used to type-check item signatures and lower them
/// from HIR to their [`ty::Ty`] representation, which is exposed using [`AstConv`].
/// It's also used for the bodies of items like structs where the body (the fields)
/// are just signatures.
///
/// This is in contrast to [`FnCtxt`], which is used to type-check bodies of
/// functions, closures, and `const`s -- anywhere that expressions and statements show up.
///
/// An important thing to note is that `ItemCtxt` does no inference -- it has no [`InferCtxt`] --
/// while `FnCtxt` does do inference.
///
/// [`FnCtxt`]: crate::check::FnCtxt
/// [`InferCtxt`]: rustc_infer::infer::InferCtxt
///
/// # Trait predicates
///
/// `ItemCtxt` has information about the predicates that are defined
/// on the trait. Unfortunately, this predicate information is /// on the trait. Unfortunately, this predicate information is
/// available in various different forms at various points in the /// available in various different forms at various points in the
/// process. So we can't just store a pointer to e.g., the AST or the /// process. So we can't just store a pointer to e.g., the AST or the