nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-22 14:55:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Replace match assertions against empty slices with is_empty assertions

Browse Source 
Asserting is_empty is slightly more concise.
This commit is contained in:
Kirby Linvill 2023-11-09 18:05:10 -07:00
parent 98228e67bc
commit 30d6733eb3
No known key found for this signature in database
GPG Key ID: E304CE3F028E6E3F
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/ui-fulldeps/stable-mir/projections.rs
View File

@ -30,11 +30,9 @@ use std::ops::ControlFlow;
const CRATE_NAME: &str = "input"; const CRATE_NAME: &str = "input";
/// This function uses the Stable MIR APIs to get information about the test crate. /// Tests projections within Place objects
fn test_projections(_tcx: TyCtxt<'_>) -> ControlFlow<()> { fn test_place_projections(_tcx: TyCtxt<'_>) -> ControlFlow<()> {
// Find items in the local crate.
let items = stable_mir::all_local_items(); let items = stable_mir::all_local_items();
let body = get_item(&items, (DefKind::Fn, "projections")).unwrap().body(); let body = get_item(&items, (DefKind::Fn, "projections")).unwrap().body();
assert_eq!(body.blocks.len(), 4); assert_eq!(body.blocks.len(), 4);
// The first statement assigns `&s.c` to a local. The projections include a deref for `s`, since // The first statement assigns `&s.c` to a local. The projections include a deref for `s`, since
@ -47,7 +45,7 @@ fn test_projections(_tcx: TyCtxt<'_>) -> ControlFlow<()> {
// We can't match on vecs, only on slices. Comparing statements for equality wouldn't be // We can't match on vecs, only on slices. Comparing statements for equality wouldn't be
// any easier since we'd then have to add in the expected local and region values // any easier since we'd then have to add in the expected local and region values
// instead of matching on wildcards. // instead of matching on wildcards.
assert_matches!(local_proj[..], []); assert!(local_proj.is_empty());
match &r_proj[..] { match &r_proj[..] {
// Similarly we can't match against a type, only against its kind. // Similarly we can't match against a type, only against its kind.
[ProjectionElem::Deref, ProjectionElem::Field(2, ty)] => assert_matches!( [ProjectionElem::Deref, ProjectionElem::Field(2, ty)] => assert_matches!(
@ -80,7 +78,7 @@ fn test_projections(_tcx: TyCtxt<'_>) -> ControlFlow<()> {
// We can't match on vecs, only on slices. Comparing for equality wouldn't be any easier // We can't match on vecs, only on slices. Comparing for equality wouldn't be any easier
// since we'd then have to add in the expected local values instead of matching on // since we'd then have to add in the expected local values instead of matching on
// wildcards. // wildcards.
assert_matches!(local_proj[..], []); assert!(local_proj.is_empty());
assert_matches!(r_proj[..], [ProjectionElem::Deref, ProjectionElem::Index(_)]); assert_matches!(r_proj[..], [ProjectionElem::Deref, ProjectionElem::Index(_)]);
} }
other => panic!( other => panic!(
@ -108,8 +106,8 @@ fn test_projections(_tcx: TyCtxt<'_>) -> ControlFlow<()> {
projection: arg2_proj, projection: arg2_proj,
}), }),
] => { ] => {
assert_matches!(arg1_proj[..], []); assert!(arg1_proj.is_empty());
assert_matches!(arg2_proj[..], []); assert!(arg2_proj.is_empty());
} }
other => { other => {
panic!( panic!(