From 2c405aea5d23b9afb33d447613d131b5ae4ef049 Mon Sep 17 00:00:00 2001 From: Camelid Date: Thu, 31 Dec 2020 12:47:09 -0800 Subject: [PATCH] Fix tests that incorrectly used `!@has` instead of `@!has` The command is `@!has`, not `!@has`. I don't think these checks were doing anything before! Ideally we would accept `!@has` as well, or at least fail tests that use `!@has`. The current behavior seems to be silently ignoring the check, which is very confusing. --- src/test/rustdoc/inline_local/trait-vis.rs | 2 +- src/test/rustdoc/issue-74083.rs | 2 +- src/test/rustdoc/remove-url-from-headings.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/test/rustdoc/inline_local/trait-vis.rs b/src/test/rustdoc/inline_local/trait-vis.rs index a997d1e25f0..a9b54fbe79e 100644 --- a/src/test/rustdoc/inline_local/trait-vis.rs +++ b/src/test/rustdoc/inline_local/trait-vis.rs @@ -14,5 +14,5 @@ mod asdf { // @has trait_vis/struct.SomeStruct.html // @has - '//code' 'impl ThisTrait for SomeStruct' -// !@has - '//code' 'impl PrivateTrait for SomeStruct' +// @!has - '//code' 'impl PrivateTrait for SomeStruct' pub use asdf::SomeStruct; diff --git a/src/test/rustdoc/issue-74083.rs b/src/test/rustdoc/issue-74083.rs index 28585dafa14..c7f5d7eaa58 100644 --- a/src/test/rustdoc/issue-74083.rs +++ b/src/test/rustdoc/issue-74083.rs @@ -7,7 +7,7 @@ impl Foo { } // @has issue_74083/struct.Bar.html -// !@has - '//div[@class="sidebar-links"]/a[@href="#method.foo"]' 'foo' +// @!has - '//div[@class="sidebar-links"]/a[@href="#method.foo"]' 'foo' pub struct Bar { foo: Foo, } diff --git a/src/test/rustdoc/remove-url-from-headings.rs b/src/test/rustdoc/remove-url-from-headings.rs index 9761c1ddbe2..e2b232a6efb 100644 --- a/src/test/rustdoc/remove-url-from-headings.rs +++ b/src/test/rustdoc/remove-url-from-headings.rs @@ -1,7 +1,7 @@ #![crate_name = "foo"] // @has foo/fn.foo.html -// !@has - '//a[@href="http://a.a"]' +// @!has - '//a[@href="http://a.a"]' // @has - '//a[@href="#implementing-stuff-somewhere"]' 'Implementing stuff somewhere' // @has - '//a[@href="#another-one-urg"]' 'Another one urg'