From 2878f98672ea8b5d69c2139a0784e41c90de1d9b Mon Sep 17 00:00:00 2001 From: yungkneez Date: Tue, 26 Apr 2022 17:01:40 -0700 Subject: [PATCH] Initialize rust-analyzer submodule on bootstrap --- src/bootstrap/bootstrap.py | 4 ++++ src/bootstrap/lib.rs | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/src/bootstrap/bootstrap.py b/src/bootstrap/bootstrap.py index ac1c47524fd..b94335b16a2 100644 --- a/src/bootstrap/bootstrap.py +++ b/src/bootstrap/bootstrap.py @@ -1147,6 +1147,10 @@ class RustBuild(object): "library/backtrace", "library/stdarch" ] + # If build.vendor is set in config.toml, we must update rust-analyzer also. + # Otherwise, the bootstrap will fail (#96456). + if self.use_vendored_sources: + submodules.append("src/tools/rust-analyzer") filtered_submodules = [] submodules_names = [] for module in submodules: diff --git a/src/bootstrap/lib.rs b/src/bootstrap/lib.rs index 59102ad9f50..f47398d45d4 100644 --- a/src/bootstrap/lib.rs +++ b/src/bootstrap/lib.rs @@ -609,7 +609,7 @@ impl Build { /// This avoids contributors checking in a submodule change by accident. pub fn maybe_update_submodules(&self) { // WARNING: keep this in sync with the submodules hard-coded in bootstrap.py - const BOOTSTRAP_SUBMODULES: &[&str] = &[ + let mut bootstrap_submodules: Vec<&str> = vec![ "src/tools/rust-installer", "src/tools/cargo", "src/tools/rls", @@ -617,6 +617,11 @@ impl Build { "library/backtrace", "library/stdarch", ]; + // As in bootstrap.py, we include `rust-analyzer` if `build.vendor` was set in + // `config.toml`. + if self.config.vendor { + bootstrap_submodules.push("src/tools/rust-analyzer"); + } // Avoid running git when there isn't a git checkout. if !self.config.submodules(&self.rust_info) { return; @@ -632,7 +637,7 @@ impl Build { // Sample output: `submodule.src/rust-installer.path src/tools/rust-installer` let submodule = Path::new(line.splitn(2, ' ').nth(1).unwrap()); // avoid updating submodules twice - if !BOOTSTRAP_SUBMODULES.iter().any(|&p| Path::new(p) == submodule) + if !bootstrap_submodules.iter().any(|&p| Path::new(p) == submodule) && channel::GitInfo::new(false, submodule).is_git() { self.update_submodule(submodule);