nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-23 07:14:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

statx probe: ENOSYS might come from a faulty FUSE driver

Browse Source 
Do the availability check regardless of the error returned from `statx`.

CC https://github.com/rust-lang/rust/pull/122079#discussion_r1564761281
This commit is contained in:
Tobias Bucher 2024-04-14 17:04:41 +02:00
parent 80399064af
commit 2325b81d04
1 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
library/std/src/sys/pal/unix/fs.rs
View File

@ -193,20 +193,17 @@ cfg_has_statx! {{
return Some(Err(err)); return Some(Err(err));
} }
// Availability not checked yet. // `ENOSYS` might come from a faulty FUSE driver.
// //
// First try the cheap way. // Other errors are not a good enough indicator either -- it is
if err.raw_os_error() == Some(libc::ENOSYS) {
STATX_SAVED_STATE.store(STATX_STATE::Unavailable as u8, Ordering::Relaxed);
return None;
}
// Error other than `ENOSYS` is not a good enough indicator -- it is
// known that `EPERM` can be returned as a result of using seccomp to // known that `EPERM` can be returned as a result of using seccomp to
// block the syscall. // block the syscall.
//
// Availability is checked by performing a call which expects `EFAULT` // Availability is checked by performing a call which expects `EFAULT`
// if the syscall is usable. // if the syscall is usable.
//
// See: https://github.com/rust-lang/rust/issues/65662 // See: https://github.com/rust-lang/rust/issues/65662
//
// FIXME this can probably just do the call if `EPERM` was received, but // FIXME this can probably just do the call if `EPERM` was received, but
// previous iteration of the code checked it for all errors and for now // previous iteration of the code checked it for all errors and for now
// this is retained. // this is retained.