mirror of
https://github.com/rust-lang/rust.git
synced 2024-11-25 00:03:43 +00:00
Fix generated PartialEq::ne
This commit is contained in:
parent
0e7135615f
commit
1c32fcfeb4
@ -1305,4 +1305,30 @@ impl Trait<u32> for Impl {
|
||||
}"#,
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_default_partial_eq() {
|
||||
check_assist(
|
||||
add_missing_default_members,
|
||||
r#"
|
||||
//- minicore: eq
|
||||
struct SomeStruct {
|
||||
data: usize,
|
||||
field: (usize, usize),
|
||||
}
|
||||
impl PartialEq for SomeStruct {$0}
|
||||
"#,
|
||||
r#"
|
||||
struct SomeStruct {
|
||||
data: usize,
|
||||
field: (usize, usize),
|
||||
}
|
||||
impl PartialEq for SomeStruct {
|
||||
$0fn ne(&self, other: &Self) -> bool {
|
||||
!self.eq(other)
|
||||
}
|
||||
}
|
||||
"#,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
@ -394,6 +394,9 @@ fn gen_hash_impl(adt: &ast::Adt, func: &ast::Fn) -> Option<()> {
|
||||
|
||||
/// Generate a `PartialEq` impl based on the fields and members of the target type.
|
||||
fn gen_partial_eq(adt: &ast::Adt, func: &ast::Fn) -> Option<()> {
|
||||
if func.name().map_or(false, |name| name.text() == "ne") {
|
||||
return None;
|
||||
}
|
||||
fn gen_eq_chain(expr: Option<ast::Expr>, cmp: ast::Expr) -> Option<ast::Expr> {
|
||||
match expr {
|
||||
Some(expr) => Some(make::expr_bin_op(expr, BinaryOp::LogicOp(LogicOp::And), cmp)),
|
||||
@ -424,7 +427,7 @@ fn gen_partial_eq(adt: &ast::Adt, func: &ast::Fn) -> Option<()> {
|
||||
// generate this code `Self` for the time being.
|
||||
|
||||
let body = match adt {
|
||||
// `Hash` cannot be derived for unions, so no default impl can be provided.
|
||||
// `PartialEq` cannot be derived for unions, so no default impl can be provided.
|
||||
ast::Adt::Union(_) => return None,
|
||||
|
||||
ast::Adt::Enum(enum_) => {
|
||||
|
@ -354,6 +354,9 @@ pub mod cmp {
|
||||
#[lang = "eq"]
|
||||
pub trait PartialEq<Rhs: ?Sized = Self> {
|
||||
fn eq(&self, other: &Rhs) -> bool;
|
||||
fn ne(&self, other: &Rhs) -> bool {
|
||||
!self.eq(other)
|
||||
}
|
||||
}
|
||||
|
||||
pub trait Eq: PartialEq<Self> {}
|
||||
|
Loading…
Reference in New Issue
Block a user