mirror of
https://github.com/rust-lang/rust.git
synced 2024-12-11 16:15:03 +00:00
Add 'positive' examples for some lints
This allows to see at a quick glance what the improved code could look like for these lints.
This commit is contained in:
parent
5815681b38
commit
1a16ac058d
@ -36,6 +36,14 @@ pub struct TypePass;
|
||||
/// values: Box<Vec<Foo>>,
|
||||
/// }
|
||||
/// ```
|
||||
///
|
||||
/// Better:
|
||||
///
|
||||
/// ```rust
|
||||
/// struct X {
|
||||
/// values: Vec<Foo>,
|
||||
/// }
|
||||
/// ```
|
||||
declare_lint! {
|
||||
pub BOX_VEC,
|
||||
Warn,
|
||||
@ -89,6 +97,12 @@ declare_lint! {
|
||||
/// ```rust
|
||||
/// fn foo(bar: &Box<T>) { ... }
|
||||
/// ```
|
||||
///
|
||||
/// Better:
|
||||
///
|
||||
/// ```rust
|
||||
/// fn foo(bar: &T) { ... }
|
||||
/// ```
|
||||
declare_lint! {
|
||||
pub BORROWED_BOX,
|
||||
Warn,
|
||||
@ -514,6 +528,12 @@ declare_lint! {
|
||||
/// ```rust
|
||||
/// fn as_u64(x: u8) -> u64 { x as u64 }
|
||||
/// ```
|
||||
///
|
||||
/// Using `::from` would look like this:
|
||||
///
|
||||
/// ```rust
|
||||
/// fn as_u64(x: u8) -> u64 { u64::from(x) }
|
||||
/// ```
|
||||
declare_lint! {
|
||||
pub CAST_LOSSLESS,
|
||||
Warn,
|
||||
@ -994,6 +1014,12 @@ impl<'tcx> Visitor<'tcx> for TypeComplexityVisitor {
|
||||
/// ```rust
|
||||
/// 'x' as u8
|
||||
/// ```
|
||||
///
|
||||
/// A better version, using the byte literal:
|
||||
///
|
||||
/// ```rust
|
||||
/// b'x'
|
||||
/// ```
|
||||
declare_lint! {
|
||||
pub CHAR_LIT_AS_U8,
|
||||
Warn,
|
||||
|
Loading…
Reference in New Issue
Block a user