Fix clearing the token

The previous version would have interpreted an empty token as
an abort of the dialog and would have not properly cleared the token.
This is now fixed by checking for `undefined` for a an abort and
by setting the token to `undefined` in order to clear it.
This commit is contained in:
Matthias Einwag 2020-09-23 01:03:34 -07:00
parent 501b516db4
commit 145bd6f701

View File

@ -393,8 +393,13 @@ async function queryForGithubToken(state: PersistentState): Promise<void> {
};
const newToken = await vscode.window.showInputBox(githubTokenOptions);
if (newToken) {
log.info("Storing new github token");
await state.updateGithubToken(newToken);
if (newToken !== undefined) {
if (newToken === "") {
log.info("Clearing github token");
await state.updateGithubToken(undefined);
} else {
log.info("Storing new github token");
await state.updateGithubToken(newToken);
}
}
}