nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-12-03 20:23:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

7708: Fixed many documentaion example issues.

Browse Source
This commit is contained in:
Chetan Khilosiya 2021-02-28 02:30:19 +05:30
parent 69a6e4c80c
commit 135c9e2027
2 changed files with 37 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
crates/ide_assists/src/handlers/generate_default_from_new.rs
View File

@ -10,13 +10,13 @@ use test_utils::mark;
// Assist: generate_default_from_new
//
// Generates default implementation from new method
// Generates default implementation from new method.
//
// ```
// struct Example { _inner: () }
//
// impl Example {
// pu|b fn new() -> Self {
// pub fn n$0ew() -> Self {
// Self { _inner: () }
// }
// }
@ -24,13 +24,13 @@ use test_utils::mark;
// ->
// ```
// struct Example { _inner: () }
//
// impl Example {
// pub fn new() -> Self {
// Self { _inner: () }
// }
// }
//
// impl Default for Example {
// fn default() -> Self {
// Self::new()
@ -62,7 +62,7 @@ pub(crate) fn generate_default_from_new(acc: &mut Assists, ctx: &AssistContext)
"Generate a Default impl from a new fn",
impl_obj.syntax().text_range(),
move |builder| {
// TODO: indentation logic can also go here.
// FIXME: indentation logic can also go here.
// let new_indent = IndentLevel::from_node(&insert_after);
let insert_location = impl_obj.syntax().text_range().end();
builder.insert(insert_location, default_fn_syntax);
@ -75,7 +75,7 @@ fn scope_for_fn_insertion_node(node: &SyntaxNode) -> Option<SyntaxNode> {
}
fn default_fn_node_for_new(struct_name: SyntaxText) -> String {
// TODO: Update the implementation to consider the code indentation.
// FIXME: Update the implementation to consider the code indentation.
format!(
r#"

31
crates/ide_assists/src/tests/generated.rs
View File

@ -439,6 +439,37 @@ impl Default for Version {
)
}
#[test]
fn doctest_generate_default_from_new() {
check_doc_test(
"generate_default_from_new",
r#####"
struct Example { _inner: () }
impl Example {
pub fn n$0ew() -> Self {
Self { _inner: () }
}
}
"#####,
r#####"
struct Example { _inner: () }
impl Example {
pub fn new() -> Self {
Self { _inner: () }
}
}
impl Default for Example {
fn default() -> Self {
Self::new()
}
}
"#####,
)
}
#[test]
fn doctest_generate_derive() {
check_doc_test(