nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-30 02:33:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enforce whitespace ascii character check for doc alias

Browse Source
This commit is contained in:
Guillaume Gomez 2020-10-06 14:29:42 +02:00
parent accc26abc0
commit 11f3476c59
5 changed files with 40 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
compiler/rustc_passes/src/check_attr.rs
View File

@ -303,6 +303,16 @@ impl CheckAttrVisitor<'tcx> {
.emit();
return false;
}
if doc_alias.starts_with(' ') || doc_alias.ends_with(' ') {
self.tcx
.sess
.struct_span_err(
meta.span(),
"`#[doc(alias = \"...\")]` cannot start or end with ' '",
)
.emit();
return false;
}
if let Some(err) = match target {
Target::Impl => Some("implementation block"),
Target::ForeignMod => Some("extern block"),

2
src/test/rustdoc-ui/check-doc-alias-attr.rs
View File

@ -12,4 +12,6 @@ pub struct Bar;
#[doc(alias = "
")] //~^ ERROR
#[doc(alias = "\t")] //~ ERROR
#[doc(alias = " hello")] //~ ERROR
#[doc(alias = "hello ")] //~ ERROR
pub struct Foo;

14
src/test/rustdoc-ui/check-doc-alias-attr.stderr
View File

@ -42,5 +42,17 @@ error: '\t' character isn't allowed in `#[doc(alias = "...")]`
LL | #[doc(alias = "\t")]
| ^^^^^^^^^^^^
error: aborting due to 7 previous errors
error: `#[doc(alias = "...")]` cannot start or end with ' '
--> $DIR/check-doc-alias-attr.rs:15:7
|
LL | #[doc(alias = " hello")]
| ^^^^^^^^^^^^^^^^
error: `#[doc(alias = "...")]` cannot start or end with ' '
--> $DIR/check-doc-alias-attr.rs:16:7
|
LL | #[doc(alias = "hello ")]
| ^^^^^^^^^^^^^^^^
error: aborting due to 9 previous errors

2
src/test/ui/check-doc-alias-attr.rs
View File

@ -12,4 +12,6 @@ pub struct Bar;
#[doc(alias = "
")] //~^ ERROR
#[doc(alias = "\t")] //~ ERROR
#[doc(alias = " hello")] //~ ERROR
#[doc(alias = "hello ")] //~ ERROR
pub struct Foo;

14
src/test/ui/check-doc-alias-attr.stderr
View File

@ -42,5 +42,17 @@ error: '\t' character isn't allowed in `#[doc(alias = "...")]`
LL | #[doc(alias = "\t")]
| ^^^^^^^^^^^^
error: aborting due to 7 previous errors
error: `#[doc(alias = "...")]` cannot start or end with ' '
--> $DIR/check-doc-alias-attr.rs:15:7
|
LL | #[doc(alias = " hello")]
| ^^^^^^^^^^^^^^^^
error: `#[doc(alias = "...")]` cannot start or end with ' '
--> $DIR/check-doc-alias-attr.rs:16:7
|
LL | #[doc(alias = "hello ")]
| ^^^^^^^^^^^^^^^^
error: aborting due to 9 previous errors