nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-24 07:44:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't lint single_component_path_imports in macros

Browse Source
This commit is contained in:
Yuki Okushi 2020-02-17 05:44:38 +09:00
parent 578960d61d
commit 09165ff576
3 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clippy_lints/src/single_component_path_imports.rs
View File

@ -1,4 +1,4 @@
use crate::utils::span_lint_and_sugg;
use crate::utils::{in_macro, span_lint_and_sugg};
use if_chain::if_chain;
use rustc_errors::Applicability;
use rustc_lint::{EarlyContext, EarlyLintPass};
@ -39,6 +39,7 @@ declare_lint_pass!(SingleComponentPathImports => [SINGLE_COMPONENT_PATH_IMPORTS]
impl EarlyLintPass for SingleComponentPathImports {
fn check_item(&mut self, cx: &EarlyContext<'_>, item: &Item) {
if_chain! {
if !in_macro(item.span);
if cx.sess.opts.edition == Edition::Edition2018;
if !item.vis.node.is_pub();
if let ItemKind::Use(use_tree) = &item.kind;

9
tests/ui/single_component_path_imports.fixed
View File

@ -7,6 +7,15 @@
use serde as edres;
pub use serde;
macro_rules! m {
() => {
use regex;
};
}
fn main() {
regex::Regex::new(r"^\d{4}-\d{2}-\d{2}$").unwrap();
// False positive #5154, shouldn't trigger lint.
m!();
}

9
tests/ui/single_component_path_imports.rs
View File

@ -7,6 +7,15 @@ use regex;
use serde as edres;
pub use serde;
macro_rules! m {
() => {
use regex;
};
}
fn main() {
regex::Regex::new(r"^\d{4}-\d{2}-\d{2}$").unwrap();
// False positive #5154, shouldn't trigger lint.
m!();
}