mirror of
https://github.com/rust-lang/rust.git
synced 2024-12-27 07:55:03 +00:00
auto merge of #7142 : alexcrichton/rust/deriving-zero, r=pcwalton
This allows mass-initialization of large structs without having to specify all the fields. I'm a bit hesitant, but I wanted to get this out there. I don't really like using the `Zero` trait, because it doesn't really make sense for a type like `HashMap` to use `Zero` as the 'blank allocation' trait. In theory there'd be a new trait, but then that's adding cruft to the language which may not necessarily need to be there. I do think that this can be useful, but I only implemented `Zero` on the basic types where I thought it made sense, so it may not be all that usable yet. (opinions?)
This commit is contained in:
commit
08c1155a22
@ -17,8 +17,8 @@ use u32;
|
||||
use uint;
|
||||
use unicode::{derived_property, general_category};
|
||||
|
||||
#[cfg(not(test))]
|
||||
use cmp::{Eq, Ord};
|
||||
#[cfg(not(test))] use cmp::{Eq, Ord};
|
||||
#[cfg(not(test))] use num::Zero;
|
||||
|
||||
/*
|
||||
Lu Uppercase_Letter an uppercase letter
|
||||
@ -328,6 +328,12 @@ impl Ord for char {
|
||||
fn ge(&self, other: &char) -> bool { *self >= *other }
|
||||
}
|
||||
|
||||
#[cfg(not(test))]
|
||||
impl Zero for char {
|
||||
fn zero() -> char { 0 as char }
|
||||
fn is_zero(&self) -> bool { *self == 0 as char }
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_is_lowercase() {
|
||||
assert!('a'.is_lowercase());
|
||||
|
@ -418,6 +418,21 @@ pub fn pow_with_uint<T:NumCast+One+Zero+Copy+Div<T,T>+Mul<T,T>>(radix: uint, pow
|
||||
total
|
||||
}
|
||||
|
||||
impl<T: Zero> Zero for @mut T {
|
||||
fn zero() -> @mut T { @mut Zero::zero() }
|
||||
fn is_zero(&self) -> bool { (**self).is_zero() }
|
||||
}
|
||||
|
||||
impl<T: Zero> Zero for @T {
|
||||
fn zero() -> @T { @Zero::zero() }
|
||||
fn is_zero(&self) -> bool { (**self).is_zero() }
|
||||
}
|
||||
|
||||
impl<T: Zero> Zero for ~T {
|
||||
fn zero() -> ~T { ~Zero::zero() }
|
||||
fn is_zero(&self) -> bool { (**self).is_zero() }
|
||||
}
|
||||
|
||||
/// Helper function for testing numeric operations
|
||||
#[cfg(test)]
|
||||
pub fn test_num<T:Num + NumCast>(ten: T, two: T) {
|
||||
|
@ -350,6 +350,11 @@ impl<T:Copy + Zero> Option<T> {
|
||||
}
|
||||
}
|
||||
|
||||
impl<T> Zero for Option<T> {
|
||||
fn zero() -> Option<T> { None }
|
||||
fn is_zero(&self) -> bool { self.is_none() }
|
||||
}
|
||||
|
||||
/// Immutable iterator over an `Option<A>`
|
||||
pub struct OptionIterator<'self, A> {
|
||||
priv opt: Option<&'self A>
|
||||
|
@ -27,6 +27,7 @@ use container::Container;
|
||||
use iter::Times;
|
||||
use iterator::{Iterator, IteratorUtil, FilterIterator, AdditiveIterator, MapIterator};
|
||||
use libc;
|
||||
use num::Zero;
|
||||
use option::{None, Option, Some};
|
||||
use old_iter::{BaseIter, EqIter};
|
||||
use ptr;
|
||||
@ -2201,6 +2202,16 @@ impl<'self> Iterator<u8> for StrBytesRevIterator<'self> {
|
||||
}
|
||||
}
|
||||
|
||||
impl Zero for ~str {
|
||||
fn zero() -> ~str { ~"" }
|
||||
fn is_zero(&self) -> bool { self.len() == 0 }
|
||||
}
|
||||
|
||||
impl Zero for @str {
|
||||
fn zero() -> @str { @"" }
|
||||
fn is_zero(&self) -> bool { self.len() == 0 }
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
mod tests {
|
||||
use iterator::IteratorUtil;
|
||||
|
@ -135,6 +135,7 @@ macro_rules! tuple_impls {
|
||||
pub mod inner {
|
||||
use clone::Clone;
|
||||
#[cfg(not(test))] use cmp::*;
|
||||
#[cfg(not(test))] use num::Zero;
|
||||
|
||||
$(
|
||||
pub trait $cloneable_trait<$($T),+> {
|
||||
@ -210,6 +211,18 @@ macro_rules! tuple_impls {
|
||||
lexical_cmp!($(self.$get_ref_fn(), other.$get_ref_fn()),+)
|
||||
}
|
||||
}
|
||||
|
||||
#[cfg(not(test))]
|
||||
impl<$($T:Zero),+> Zero for ($($T),+) {
|
||||
#[inline]
|
||||
fn zero() -> ($($T),+) {
|
||||
($(Zero::zero::<$T>()),+)
|
||||
}
|
||||
#[inline]
|
||||
fn is_zero(&self) -> bool {
|
||||
$(self.$get_ref_fn().is_zero())&&+
|
||||
}
|
||||
}
|
||||
)+
|
||||
}
|
||||
}
|
||||
|
@ -23,6 +23,7 @@ use iterator::{Iterator, IteratorUtil};
|
||||
use iter::FromIter;
|
||||
use kinds::Copy;
|
||||
use libc;
|
||||
use num::Zero;
|
||||
use old_iter::CopyableIter;
|
||||
use option::{None, Option, Some};
|
||||
use ptr::to_unsafe_ptr;
|
||||
@ -2628,6 +2629,16 @@ impl<A:Clone> Clone for ~[A] {
|
||||
}
|
||||
}
|
||||
|
||||
impl<A> Zero for ~[A] {
|
||||
fn zero() -> ~[A] { ~[] }
|
||||
fn is_zero(&self) -> bool { self.len() == 0 }
|
||||
}
|
||||
|
||||
impl<A> Zero for @[A] {
|
||||
fn zero() -> @[A] { @[] }
|
||||
fn is_zero(&self) -> bool { self.len() == 0 }
|
||||
}
|
||||
|
||||
macro_rules! iterator {
|
||||
/* FIXME: #4375 Cannot attach documentation/attributes to a macro generated struct.
|
||||
(struct $name:ident -> $ptr:ty, $elem:ty) => {
|
||||
|
@ -31,6 +31,7 @@ pub mod encodable;
|
||||
pub mod decodable;
|
||||
pub mod rand;
|
||||
pub mod to_str;
|
||||
pub mod zero;
|
||||
|
||||
#[path="cmp/eq.rs"]
|
||||
pub mod eq;
|
||||
@ -98,6 +99,7 @@ pub fn expand_meta_deriving(cx: @ExtCtxt,
|
||||
"Rand" => expand!(rand::expand_deriving_rand),
|
||||
|
||||
"ToStr" => expand!(to_str::expand_deriving_to_str),
|
||||
"Zero" => expand!(zero::expand_deriving_zero),
|
||||
|
||||
ref tname => {
|
||||
cx.span_err(titem.span, fmt!("unknown \
|
||||
|
96
src/libsyntax/ext/deriving/zero.rs
Normal file
96
src/libsyntax/ext/deriving/zero.rs
Normal file
@ -0,0 +1,96 @@
|
||||
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
|
||||
// file at the top-level directory of this distribution and at
|
||||
// http://rust-lang.org/COPYRIGHT.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
// option. This file may not be copied, modified, or distributed
|
||||
// except according to those terms.
|
||||
|
||||
use core::prelude::*;
|
||||
|
||||
use ast::{meta_item, item, expr};
|
||||
use codemap::span;
|
||||
use ext::base::ExtCtxt;
|
||||
use ext::build::AstBuilder;
|
||||
use ext::deriving::generic::*;
|
||||
|
||||
use core::vec;
|
||||
|
||||
pub fn expand_deriving_zero(cx: @ExtCtxt,
|
||||
span: span,
|
||||
mitem: @meta_item,
|
||||
in_items: ~[@item])
|
||||
-> ~[@item] {
|
||||
let trait_def = TraitDef {
|
||||
path: Path::new(~["std", "num", "Zero"]),
|
||||
additional_bounds: ~[],
|
||||
generics: LifetimeBounds::empty(),
|
||||
methods: ~[
|
||||
MethodDef {
|
||||
name: "zero",
|
||||
generics: LifetimeBounds::empty(),
|
||||
explicit_self: None,
|
||||
args: ~[],
|
||||
ret_ty: Self,
|
||||
const_nonmatching: false,
|
||||
combine_substructure: zero_substructure
|
||||
},
|
||||
MethodDef {
|
||||
name: "is_zero",
|
||||
generics: LifetimeBounds::empty(),
|
||||
explicit_self: borrowed_explicit_self(),
|
||||
args: ~[],
|
||||
ret_ty: Literal(Path::new(~["bool"])),
|
||||
const_nonmatching: false,
|
||||
combine_substructure: |cx, span, substr| {
|
||||
cs_and(|cx, span, _, _| cx.span_bug(span,
|
||||
"Non-matching enum \
|
||||
variant in \
|
||||
deriving(Zero)"),
|
||||
cx, span, substr)
|
||||
}
|
||||
}
|
||||
]
|
||||
};
|
||||
trait_def.expand(cx, span, mitem, in_items)
|
||||
}
|
||||
|
||||
fn zero_substructure(cx: @ExtCtxt, span: span, substr: &Substructure) -> @expr {
|
||||
let zero_ident = ~[
|
||||
cx.ident_of("std"),
|
||||
cx.ident_of("num"),
|
||||
cx.ident_of("Zero"),
|
||||
cx.ident_of("zero")
|
||||
];
|
||||
let zero_call = || {
|
||||
cx.expr_call_global(span, copy zero_ident, ~[])
|
||||
};
|
||||
|
||||
return match *substr.fields {
|
||||
StaticStruct(_, ref summary) => {
|
||||
match *summary {
|
||||
Left(count) => {
|
||||
if count == 0 {
|
||||
cx.expr_ident(span, substr.type_ident)
|
||||
} else {
|
||||
let exprs = vec::from_fn(count, |_| zero_call());
|
||||
cx.expr_call_ident(span, substr.type_ident, exprs)
|
||||
}
|
||||
}
|
||||
Right(ref fields) => {
|
||||
let zero_fields = do fields.map |ident| {
|
||||
cx.field_imm(span, *ident, zero_call())
|
||||
};
|
||||
cx.expr_struct_ident(span, substr.type_ident, zero_fields)
|
||||
}
|
||||
}
|
||||
}
|
||||
StaticEnum(*) => {
|
||||
cx.span_fatal(span, "`Zero` cannot be derived for enums, \
|
||||
only structs")
|
||||
}
|
||||
_ => cx.bug("Non-static method in `deriving(Zero)`")
|
||||
};
|
||||
}
|
40
src/test/run-pass/deriving-zero.rs
Normal file
40
src/test/run-pass/deriving-zero.rs
Normal file
@ -0,0 +1,40 @@
|
||||
// Copyright 2012-2013 The Rust Project Developers. See the COPYRIGHT
|
||||
// file at the top-level directory of this distribution and at
|
||||
// http://rust-lang.org/COPYRIGHT.
|
||||
//
|
||||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
// option. This file may not be copied, modified, or distributed
|
||||
// except according to those terms.
|
||||
|
||||
use std::util;
|
||||
use std::num::Zero;
|
||||
|
||||
#[deriving(Zero)]
|
||||
struct A;
|
||||
#[deriving(Zero)]
|
||||
struct B(int);
|
||||
#[deriving(Zero)]
|
||||
struct C(int, int);
|
||||
#[deriving(Zero)]
|
||||
struct D { a: int }
|
||||
#[deriving(Zero)]
|
||||
struct E { a: int, b: int }
|
||||
|
||||
#[deriving(Zero)]
|
||||
struct Lots {
|
||||
a: ~str,
|
||||
b: @str,
|
||||
c: Option<util::NonCopyable>,
|
||||
d: u8,
|
||||
e: char,
|
||||
f: float,
|
||||
g: (f32, char),
|
||||
h: ~[util::NonCopyable],
|
||||
i: @mut (int, int),
|
||||
}
|
||||
|
||||
fn main() {
|
||||
assert!(Zero::zero::<Lots>().is_zero());
|
||||
}
|
Loading…
Reference in New Issue
Block a user