2021-05-06 09:51:22 +00:00
|
|
|
//! This test is a part of quality control and makes clippy eat what it produces. Awesome lints and
|
|
|
|
//! long error messages
|
|
|
|
//!
|
|
|
|
//! See [Eating your own dog food](https://en.wikipedia.org/wiki/Eating_your_own_dog_food) for context
|
|
|
|
|
2020-02-09 05:00:49 +00:00
|
|
|
// Dogfood cannot run on Windows
|
|
|
|
#![cfg(not(windows))]
|
2020-10-09 10:45:29 +00:00
|
|
|
#![feature(once_cell)]
|
2020-02-09 05:00:49 +00:00
|
|
|
|
2020-10-09 10:45:29 +00:00
|
|
|
use std::lazy::SyncLazy;
|
2021-03-12 14:30:50 +00:00
|
|
|
use std::path::PathBuf;
|
2020-02-01 17:00:48 +00:00
|
|
|
use std::process::Command;
|
|
|
|
|
|
|
|
mod cargo;
|
|
|
|
|
2020-10-09 10:45:29 +00:00
|
|
|
static CLIPPY_PATH: SyncLazy<PathBuf> = SyncLazy::new(|| cargo::TARGET_LIB.join("cargo-clippy"));
|
2020-02-01 17:00:48 +00:00
|
|
|
|
2017-12-15 09:02:39 +00:00
|
|
|
#[test]
|
2019-09-11 18:52:36 +00:00
|
|
|
fn dogfood_clippy() {
|
|
|
|
// run clippy on itself and fail the test if lint warnings are reported
|
2020-02-09 05:00:49 +00:00
|
|
|
if cargo::is_rustc_test_suite() {
|
2018-01-18 21:02:58 +00:00
|
|
|
return;
|
|
|
|
}
|
2020-02-01 17:00:48 +00:00
|
|
|
let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
|
2018-11-21 15:14:42 +00:00
|
|
|
|
2020-12-06 14:01:03 +00:00
|
|
|
let mut command = Command::new(&*CLIPPY_PATH);
|
|
|
|
command
|
2018-11-30 18:54:47 +00:00
|
|
|
.current_dir(root_dir)
|
2018-11-24 21:24:13 +00:00
|
|
|
.env("CLIPPY_DOGFOOD", "1")
|
2019-09-06 17:35:20 +00:00
|
|
|
.env("CARGO_INCREMENTAL", "0")
|
2021-03-12 14:30:50 +00:00
|
|
|
.arg("clippy")
|
2018-11-21 15:14:42 +00:00
|
|
|
.arg("--all-targets")
|
|
|
|
.arg("--all-features")
|
|
|
|
.arg("--")
|
|
|
|
.args(&["-D", "clippy::all"])
|
|
|
|
.args(&["-D", "clippy::pedantic"])
|
2020-12-06 14:01:03 +00:00
|
|
|
.arg("-Cdebuginfo=0"); // disable debuginfo to generate less data in the target dir
|
|
|
|
|
|
|
|
// internal lints only exist if we build with the internal-lints feature
|
|
|
|
if cfg!(feature = "internal-lints") {
|
|
|
|
command.args(&["-D", "clippy::internal"]);
|
|
|
|
}
|
|
|
|
|
|
|
|
let output = command.output().unwrap();
|
|
|
|
|
2018-11-21 15:14:42 +00:00
|
|
|
println!("status: {}", output.status);
|
|
|
|
println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
|
|
|
|
println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
|
|
|
|
|
|
|
|
assert!(output.status.success());
|
|
|
|
}
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
fn test_no_deps_ignores_path_deps_in_workspaces() {
|
|
|
|
if cargo::is_rustc_test_suite() {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
let root = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
|
|
|
|
let target_dir = root.join("target").join("dogfood");
|
|
|
|
let cwd = root.join("clippy_workspace_tests");
|
|
|
|
|
|
|
|
// Make sure we start with a clean state
|
|
|
|
Command::new("cargo")
|
|
|
|
.current_dir(&cwd)
|
|
|
|
.env("CARGO_TARGET_DIR", &target_dir)
|
|
|
|
.arg("clean")
|
|
|
|
.args(&["-p", "subcrate"])
|
|
|
|
.args(&["-p", "path_dep"])
|
|
|
|
.output()
|
|
|
|
.unwrap();
|
|
|
|
|
|
|
|
// `path_dep` is a path dependency of `subcrate` that would trigger a denied lint.
|
|
|
|
// Make sure that with the `--no-deps` argument Clippy does not run on `path_dep`.
|
|
|
|
let output = Command::new(&*CLIPPY_PATH)
|
|
|
|
.current_dir(&cwd)
|
|
|
|
.env("CLIPPY_DOGFOOD", "1")
|
|
|
|
.env("CARGO_INCREMENTAL", "0")
|
|
|
|
.arg("clippy")
|
|
|
|
.args(&["-p", "subcrate"])
|
|
|
|
.arg("--no-deps")
|
2021-07-29 10:16:06 +00:00
|
|
|
.arg("--")
|
2021-03-12 14:30:50 +00:00
|
|
|
.arg("-Cdebuginfo=0") // disable debuginfo to generate less data in the target dir
|
|
|
|
.args(&["--cfg", r#"feature="primary_package_test""#])
|
|
|
|
.output()
|
|
|
|
.unwrap();
|
|
|
|
println!("status: {}", output.status);
|
|
|
|
println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
|
|
|
|
println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
|
2020-12-20 16:19:49 +00:00
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
assert!(output.status.success());
|
2020-12-20 16:19:49 +00:00
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
let lint_path_dep = || {
|
|
|
|
// Test that without the `--no-deps` argument, `path_dep` is linted.
|
2020-12-20 16:19:49 +00:00
|
|
|
let output = Command::new(&*CLIPPY_PATH)
|
|
|
|
.current_dir(&cwd)
|
|
|
|
.env("CLIPPY_DOGFOOD", "1")
|
|
|
|
.env("CARGO_INCREMENTAL", "0")
|
|
|
|
.arg("clippy")
|
|
|
|
.args(&["-p", "subcrate"])
|
|
|
|
.arg("--")
|
|
|
|
.arg("-Cdebuginfo=0") // disable debuginfo to generate less data in the target dir
|
|
|
|
.args(&["--cfg", r#"feature="primary_package_test""#])
|
|
|
|
.output()
|
|
|
|
.unwrap();
|
|
|
|
println!("status: {}", output.status);
|
|
|
|
println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
|
|
|
|
println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
assert!(!output.status.success());
|
|
|
|
assert!(
|
|
|
|
String::from_utf8(output.stderr)
|
|
|
|
.unwrap()
|
|
|
|
.contains("error: empty `loop {}` wastes CPU cycles")
|
|
|
|
);
|
|
|
|
};
|
2020-12-20 16:19:49 +00:00
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
// Make sure Cargo is aware of the removal of `--no-deps`.
|
|
|
|
lint_path_dep();
|
2020-12-20 16:19:49 +00:00
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
let successful_build = || {
|
2020-12-20 16:19:49 +00:00
|
|
|
let output = Command::new(&*CLIPPY_PATH)
|
|
|
|
.current_dir(&cwd)
|
|
|
|
.env("CLIPPY_DOGFOOD", "1")
|
|
|
|
.env("CARGO_INCREMENTAL", "0")
|
|
|
|
.arg("clippy")
|
|
|
|
.args(&["-p", "subcrate"])
|
|
|
|
.arg("--")
|
|
|
|
.arg("-Cdebuginfo=0") // disable debuginfo to generate less data in the target dir
|
|
|
|
.output()
|
|
|
|
.unwrap();
|
|
|
|
println!("status: {}", output.status);
|
|
|
|
println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
|
|
|
|
println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
|
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
assert!(output.status.success());
|
|
|
|
|
|
|
|
output
|
|
|
|
};
|
2020-12-20 16:19:49 +00:00
|
|
|
|
2021-03-12 14:30:50 +00:00
|
|
|
// Trigger a sucessful build, so Cargo would like to cache the build result.
|
|
|
|
successful_build();
|
|
|
|
|
|
|
|
// Make sure there's no spurious rebuild when nothing changes.
|
|
|
|
let stderr = String::from_utf8(successful_build().stderr).unwrap();
|
|
|
|
assert!(!stderr.contains("Compiling"));
|
|
|
|
assert!(!stderr.contains("Checking"));
|
|
|
|
assert!(stderr.contains("Finished"));
|
|
|
|
|
|
|
|
// Make sure Cargo is aware of the new `--cfg` flag.
|
|
|
|
lint_path_dep();
|
|
|
|
}
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
fn dogfood_subprojects() {
|
2019-09-11 18:52:36 +00:00
|
|
|
// run clippy on remaining subprojects and fail the test if lint warnings are reported
|
2020-02-09 05:00:49 +00:00
|
|
|
if cargo::is_rustc_test_suite() {
|
2018-11-21 15:14:42 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-12-20 16:19:49 +00:00
|
|
|
// NOTE: `path_dep` crate is omitted on purpose here
|
2021-05-20 10:30:31 +00:00
|
|
|
for project in &[
|
2018-11-21 15:14:42 +00:00
|
|
|
"clippy_workspace_tests",
|
|
|
|
"clippy_workspace_tests/src",
|
|
|
|
"clippy_workspace_tests/subcrate",
|
|
|
|
"clippy_workspace_tests/subcrate/src",
|
|
|
|
"clippy_dev",
|
2021-03-12 14:30:50 +00:00
|
|
|
"clippy_lints",
|
|
|
|
"clippy_utils",
|
2018-11-21 15:14:42 +00:00
|
|
|
"rustc_tools_util",
|
|
|
|
] {
|
2021-05-20 10:30:31 +00:00
|
|
|
run_clippy_for_project(project);
|
|
|
|
}
|
|
|
|
|
|
|
|
// NOTE: Since tests run in parallel we can't run cargo commands on the same workspace at the
|
|
|
|
// same time, so we test this immediately after the dogfood for workspaces.
|
|
|
|
test_no_deps_ignores_path_deps_in_workspaces();
|
|
|
|
}
|
2021-03-12 14:30:50 +00:00
|
|
|
|
2021-05-20 10:30:31 +00:00
|
|
|
#[test]
|
|
|
|
#[ignore]
|
|
|
|
#[cfg(feature = "metadata-collector-lint")]
|
|
|
|
fn run_metadata_collection_lint() {
|
2021-06-03 06:41:37 +00:00
|
|
|
use std::fs::File;
|
|
|
|
use std::time::SystemTime;
|
|
|
|
|
|
|
|
// Setup for validation
|
2021-07-29 10:16:06 +00:00
|
|
|
let metadata_output_path = PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("util/gh-pages/lints.json");
|
2021-06-03 06:41:37 +00:00
|
|
|
let start_time = SystemTime::now();
|
|
|
|
|
|
|
|
// Run collection as is
|
2021-05-20 10:30:31 +00:00
|
|
|
std::env::set_var("ENABLE_METADATA_COLLECTION", "1");
|
|
|
|
run_clippy_for_project("clippy_lints");
|
2021-06-03 06:41:37 +00:00
|
|
|
|
|
|
|
// Check if cargo caching got in the way
|
|
|
|
if let Ok(file) = File::open(metadata_output_path) {
|
|
|
|
if let Ok(metadata) = file.metadata() {
|
|
|
|
if let Ok(last_modification) = metadata.modified() {
|
|
|
|
if last_modification > start_time {
|
|
|
|
// The output file has been modified. Most likely by a hungry
|
|
|
|
// metadata collection monster. So We'll return.
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Force cargo to invalidate the caches
|
|
|
|
filetime::set_file_mtime(
|
|
|
|
PathBuf::from(env!("CARGO_MANIFEST_DIR")).join("clippy_lints/src/lib.rs"),
|
|
|
|
filetime::FileTime::now(),
|
|
|
|
)
|
|
|
|
.unwrap();
|
|
|
|
|
|
|
|
// Running the collection again
|
|
|
|
run_clippy_for_project("clippy_lints");
|
2021-05-20 10:30:31 +00:00
|
|
|
}
|
2021-03-12 14:30:50 +00:00
|
|
|
|
2021-05-20 10:30:31 +00:00
|
|
|
fn run_clippy_for_project(project: &str) {
|
|
|
|
let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
|
2021-03-12 14:30:50 +00:00
|
|
|
|
2021-05-20 10:30:31 +00:00
|
|
|
let mut command = Command::new(&*CLIPPY_PATH);
|
2017-12-15 09:02:39 +00:00
|
|
|
|
2021-05-20 10:30:31 +00:00
|
|
|
command
|
|
|
|
.current_dir(root_dir.join(project))
|
|
|
|
.env("CLIPPY_DOGFOOD", "1")
|
|
|
|
.env("CARGO_INCREMENTAL", "0")
|
|
|
|
.arg("clippy")
|
|
|
|
.arg("--all-targets")
|
|
|
|
.arg("--all-features")
|
|
|
|
.arg("--")
|
|
|
|
.args(&["-D", "clippy::all"])
|
|
|
|
.args(&["-D", "clippy::pedantic"])
|
|
|
|
.arg("-Cdebuginfo=0"); // disable debuginfo to generate less data in the target dir
|
|
|
|
|
|
|
|
// internal lints only exist if we build with the internal-lints feature
|
|
|
|
if cfg!(feature = "internal-lints") {
|
|
|
|
command.args(&["-D", "clippy::internal"]);
|
2017-12-15 09:02:39 +00:00
|
|
|
}
|
2020-12-20 16:19:49 +00:00
|
|
|
|
2021-05-20 10:30:31 +00:00
|
|
|
let output = command.output().unwrap();
|
|
|
|
|
|
|
|
println!("status: {}", output.status);
|
|
|
|
println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
|
|
|
|
println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
|
|
|
|
|
|
|
|
assert!(output.status.success());
|
2017-12-15 09:02:39 +00:00
|
|
|
}
|