nordic-dev.net/rust
nordic-dev.net/rust
2
0
Fork 0
mirror of https://github.com/rust-lang/rust.git synced 2024-11-26 00:34:06 +00:00
Code Issues Packages Projects Releases Wiki Activity
f4f96e2943
rust/src/test/ui/lint/issue-47390-unused-variable-in-struct-pattern.stderr

125 lines
4.5 KiB
Plaintext
Raw Normal View History

concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
warning: unused variable: `i_think_continually`
Remove licenses
2018-12-25 15:56:47 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:26:9
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
|
Update UI tests
2018-02-23 00:42:32 +00:00
LL | let i_think_continually = 2;
Unused variable suggestions on all patterns. This commit extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.
2019-01-25 15:56:27 +00:00
| ^^^^^^^^^^^^^^^^^^^ help: consider prefixing with an underscore: `_i_think_continually`
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
|
note: lint level defined here
Remove licenses
2018-12-25 15:56:47 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:5:9
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
|
Update UI tests
2018-02-23 00:42:32 +00:00
LL | #![warn(unused)] // UI tests pass `-A unused` (#43896)
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
| ^^^^^^
normalize use of backticks in compiler messages for librustc/lint https://github.com/rust-lang/rust/issues/60532
2019-07-16 20:17:38 +00:00
= note: `#[warn(unused_variables)]` implied by `#[warn(unused)]`
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
reduce variable span
2018-05-11 14:24:04 +00:00
warning: unused variable: `mut_unused_var`
Remove licenses
2018-12-25 15:56:47 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:33:13
reduce variable span
2018-05-11 14:24:04 +00:00
|
LL | let mut mut_unused_var = 1;
Unused variable suggestions on all patterns. This commit extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.
2019-01-25 15:56:27 +00:00
| ^^^^^^^^^^^^^^ help: consider prefixing with an underscore: `_mut_unused_var`
reduce variable span
2018-05-11 14:24:04 +00:00
warning: unused variable: `var`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:37:14
reduce variable span
2018-05-11 14:24:04 +00:00
|
LL | let (mut var, unused_var) = (1, 2);
Unused variable suggestions on all patterns. This commit extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.
2019-01-25 15:56:27 +00:00
| ^^^ help: consider prefixing with an underscore: `_var`
reduce variable span
2018-05-11 14:24:04 +00:00
warning: unused variable: `unused_var`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:37:19
reduce variable span
2018-05-11 14:24:04 +00:00
|
LL | let (mut var, unused_var) = (1, 2);
Unused variable suggestions on all patterns. This commit extends existing suggestions to prefix unused variable bindings in match arms with an underscore so that it applies to all patterns in a match arm.
2019-01-25 15:56:27 +00:00
| ^^^^^^^^^^ help: consider prefixing with an underscore: `_unused_var`
reduce variable span
2018-05-11 14:24:04 +00:00
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
warning: unused variable: `corridors_of_light`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:45:26
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
|
Update UI tests
2018-02-23 00:42:32 +00:00
LL | if let SoulHistory { corridors_of_light,
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
| ^^^^^^^^^^^^^^^^^^ help: try ignoring the field: `corridors_of_light: _`
warning: variable `hours_are_suns` is assigned to, but never used
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:46:30
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
|
Update UI tests
2018-02-23 00:42:32 +00:00
LL | mut hours_are_suns,
reduce variable span
2018-05-11 14:24:04 +00:00
| ^^^^^^^^^^^^^^
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
|
= note: consider using `_hours_are_suns` instead
warning: value assigned to `hours_are_suns` is never read
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:48:9
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
|
Update UI tests
2018-02-23 00:42:32 +00:00
LL | hours_are_suns = false;
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
| ^^^^^^^^^^^^^^
|
note: lint level defined here
Remove licenses
2018-12-25 15:56:47 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:5:9
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
|
Update UI tests
2018-02-23 00:42:32 +00:00
LL | #![warn(unused)] // UI tests pass `-A unused` (#43896)
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
| ^^^^^^
normalize use of backticks in compiler messages for librustc/lint https://github.com/rust-lang/rust/issues/60532
2019-07-16 20:17:38 +00:00
= note: `#[warn(unused_assignments)]` implied by `#[warn(unused)]`
Change to give a help message
2018-12-07 14:15:36 +00:00
= help: maybe it is overwritten before being read?
concerning well-formed suggestions for unused shorthand field patterns Previously, unused variables would get a note that the warning could be silenced by prefixing the variable with an underscore, but that doesn't work for field shorthand patterns, which the liveness analysis didn't know about. The "to avoid this warning" verbiage seemed unnecessary. Resolves #47390.
2018-02-01 04:56:01 +00:00
in which the unused shorthand field pattern debacle/saga continues In e4b1a79 (#47922), we corrected erroneous suggestions for unused shorthand field pattern bindings, suggesting `field: _` where the previous suggestion of `_field` wouldn't even have compiled (#47390). Soon, it was revealed that this was insufficient (#50303), and the fix was extended to references, slices, &c. (#50327) But even this proved inadequate, as the erroneous suggestions were still being issued for patterns in local (`let`) bindings (#50804). Here, we yank the shorthand-detection and variable/node registration code into a new common function that can be called while visiting both match arms and `let` bindings. Resolves #50804.
2018-05-18 07:07:31 +00:00
warning: unused variable: `fire`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:52:32
in which the unused shorthand field pattern debacle/saga continues In e4b1a79 (#47922), we corrected erroneous suggestions for unused shorthand field pattern bindings, suggesting `field: _` where the previous suggestion of `_field` wouldn't even have compiled (#47390). Soon, it was revealed that this was insufficient (#50303), and the fix was extended to references, slices, &c. (#50327) But even this proved inadequate, as the erroneous suggestions were still being issued for patterns in local (`let`) bindings (#50804). Here, we yank the shorthand-detection and variable/node registration code into a new common function that can be called while visiting both match arms and `let` bindings. Resolves #50804.
2018-05-18 07:07:31 +00:00
|
LL | let LovelyAmbition { lips, fire } = the_spirit;
| ^^^^ help: try ignoring the field: `fire: _`
Correct unused field warning on &struct match
2018-04-29 23:40:11 +00:00
warning: unused variable: `case`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:61:23
Correct unused field warning on struct match container patterns
2018-04-30 00:27:37 +00:00
|
LL | Large::Suit { case } => {}
| ^^^^ help: try ignoring the field: `case: _`
warning: unused variable: `case`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:66:24
Correct unused field warning on &struct match
2018-04-29 23:40:11 +00:00
|
LL | &Large::Suit { case } => {}
| ^^^^ help: try ignoring the field: `case: _`
Correct unused field warning on box struct match
2018-04-29 23:51:02 +00:00
warning: unused variable: `case`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:71:27
Correct unused field warning on box struct match
2018-04-29 23:51:02 +00:00
|
LL | box Large::Suit { case } => {}
| ^^^^ help: try ignoring the field: `case: _`
Correct unused field warning on struct match container patterns
2018-04-30 00:27:37 +00:00
warning: unused variable: `case`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:76:24
Correct unused field warning on struct match container patterns
2018-04-30 00:27:37 +00:00
|
LL | (Large::Suit { case },) => {}
| ^^^^ help: try ignoring the field: `case: _`
warning: unused variable: `case`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:81:24
Correct unused field warning on struct match container patterns
2018-04-30 00:27:37 +00:00
|
LL | [Large::Suit { case }] => {}
| ^^^^ help: try ignoring the field: `case: _`
warning: unused variable: `case`
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:86:29
Correct unused field warning on struct match container patterns
2018-04-30 00:27:37 +00:00
|
LL | Tuple(Large::Suit { case }, ()) => {}
| ^^^^ help: try ignoring the field: `case: _`
reduce variable span
2018-05-11 14:24:04 +00:00
warning: variable does not need to be mutable
Remove licenses
2018-12-25 15:56:47 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:33:9
reduce variable span
2018-05-11 14:24:04 +00:00
|
LL | let mut mut_unused_var = 1;
| ----^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
note: lint level defined here
Remove licenses
2018-12-25 15:56:47 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:5:9
reduce variable span
2018-05-11 14:24:04 +00:00
|
LL | #![warn(unused)] // UI tests pass `-A unused` (#43896)
| ^^^^^^
normalize use of backticks in compiler messages for librustc/lint https://github.com/rust-lang/rust/issues/60532
2019-07-16 20:17:38 +00:00
= note: `#[warn(unused_mut)]` implied by `#[warn(unused)]`
reduce variable span
2018-05-11 14:24:04 +00:00
warning: variable does not need to be mutable
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
2019-11-06 00:00:00 +00:00
--> $DIR/issue-47390-unused-variable-in-struct-pattern.rs:37:10
reduce variable span
2018-05-11 14:24:04 +00:00
|
LL | let (mut var, unused_var) = (1, 2);
| ----^^^
| |
| help: remove this `mut`
Reference in New Issue Copy Permalink