2019-04-10 23:40:12 +00:00
error[E0658]: the `#[rustc_variance]` attribute is just used for rustc unit tests and will never be stable
2021-04-03 11:05:11 +00:00
--> $DIR/feature-gate-rustc-attrs-1.rs:3:1
2018-08-11 13:40:08 +00:00
|
2019-03-09 12:03:44 +00:00
LL | #[rustc_variance]
2018-08-11 13:40:08 +00:00
| ^^^^^^^^^^^^^^^^^
|
2019-07-09 09:32:08 +00:00
= help: add `#![feature(rustc_attrs)]` to the crate attributes to enable
2018-08-11 13:40:08 +00:00
2019-04-10 23:40:12 +00:00
error[E0658]: the `#[rustc_error]` attribute is just used for rustc unit tests and will never be stable
2021-04-03 11:05:11 +00:00
--> $DIR/feature-gate-rustc-attrs-1.rs:4:1
2018-08-11 13:40:08 +00:00
|
2019-03-09 12:03:44 +00:00
LL | #[rustc_error]
2018-08-11 13:40:08 +00:00
| ^^^^^^^^^^^^^^
|
2019-07-09 09:32:08 +00:00
= help: add `#![feature(rustc_attrs)]` to the crate attributes to enable
2018-08-11 13:40:08 +00:00
Generalize `get_nullable_type` to allow types where null is all-ones.
Generalize get_nullable_type to accept types that have an all-ones bit
pattern as their sentry "null" value.
This will allow [`OwnedFd`], [`BorrowedFd`], [`OwnedSocket`], and
[`BorrowedSocket`] to be marked with
`#[rustc_nonnull_optimization_guaranteed]`, which will allow
`Option<OwnedFd>`, `Option<BorrowedFd>`, `Option<OwnedSocket>`, and
`Option<BorrowedSocket>` to be used in FFI declarations, as described
in the [I/O safety RFC].
For example, it will allow a function like `open` on Unix and `WSASocketW`
on Windows to be declared using `Option<OwnedFd>` and `Option<OwnedSocket>`
return types, respectively.
The actual change to add `#[rustc_nonnull_optimization_guaranteed]`
to the abovementioned types will be a separate PR, as it'll depend on
having this patch in the stage0 compiler.
Also, update the diagnostics to mention that "niche optimizations" are
used in libstd as well as libcore, as `rustc_layout_scalar_valid_range_start`
and `rustc_layout_scalar_valid_range_end` are already in use in libstd.
[`OwnedFd`]: https://github.com/rust-lang/rust/blob/c9dc44be24c58ff13ce46416c4b97ab5c1bd8429/library/std/src/os/fd/owned.rs#L49
[`BorrowedFd`]: https://github.com/rust-lang/rust/blob/c9dc44be24c58ff13ce46416c4b97ab5c1bd8429/library/std/src/os/fd/owned.rs#L29
[`OwnedSocket`]: https://github.com/rust-lang/rust/blob/c9dc44be24c58ff13ce46416c4b97ab5c1bd8429/library/std/src/os/windows/io/socket.rs#L51
[`BorrowedSocket`]: https://github.com/rust-lang/rust/blob/c9dc44be24c58ff13ce46416c4b97ab5c1bd8429/library/std/src/os/windows/io/socket.rs#L29
[I/O safety RFC]: https://github.com/rust-lang/rfcs/blob/master/text/3128-io-safety.md#ownedfd-and-borrowedfdfd-1
2022-03-03 22:41:10 +00:00
error[E0658]: the `#[rustc_nonnull_optimization_guaranteed]` attribute is just used to enable niche optimizations in libcore and libstd and will never be stable
2021-04-03 11:05:11 +00:00
--> $DIR/feature-gate-rustc-attrs-1.rs:5:1
2019-05-22 13:49:43 +00:00
|
LL | #[rustc_nonnull_optimization_guaranteed]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2019-07-09 09:32:08 +00:00
= help: add `#![feature(rustc_attrs)]` to the crate attributes to enable
2019-05-22 13:49:43 +00:00
error: aborting due to 3 previous errors
2018-08-11 13:40:08 +00:00
2019-01-28 21:28:44 +00:00
For more information about this error, try `rustc --explain E0658`.